ci: make yarn install --immutable explicit in CI workflows - #10389
ci: make yarn install --immutable explicit in CI workflows#10389dev-hari-prasad wants to merge 2 commits into
Conversation
Yarn's enableImmutableInstalls already defaults to true when CI is set in the environment. Passing --immutable explicitly makes the intent clear and self-documenting in all CI workflows that invoke Yarn.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. WalkthroughYarn installation commands in four workflows, the Docker build, the Makefile, and Linux, macOS, and pip build scripts now use ChangesCI install consistency
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to CI and build/package installs now reject lockfile drift instead of rewriting dependencies. The focused edits introduce no unresolved merge-blocking risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I would like to take this, but widened a little first. On the four workflows the flag is documentation only, since
All five run with Add those five to what you already have and I will merge it. The other four PRs in the series are merged, and I have closed #10392 with an explanation. |
…rfile Enforce immutable lockfile installs in Makefile, Dockerfile, and packaging scripts (pip, linux, mac) so release and local build processes fail if yarn.lock is modified instead of silently rewriting it.
|
The requested changes are in place exactly as you asked for them. We can merge this and close #10363. |
Part of #10363.
Yarn's
enableImmutableInstallssetting already defaults totruewhenCIis present in the environment (such as in GitHub Actions). Passing--immutableexplicitly in CI workflows keeps this enforcement self-documenting and transparent.Additionally, this adds
--immutableto build and packaging scripts outside CI (Makefile,Dockerfile, and packaging build scripts for pip, Linux, and macOS) so release and local build processes fail loudly ifyarn.lockwould be modified instead of silently rewriting it.Changes
--immutabletoyarn installin GitHub Actions workflows:.github/workflows/check-javascript-style.yml.github/workflows/run-javascript-tests.yml.github/workflows/run-feature-tests-epas.yml.github/workflows/run-feature-tests-pg.yml--immutabletoyarn installin build and packaging scripts:MakefileDockerfilepkg/pip/build.shpkg/linux/build-functions.shpkg/mac/build-functions.shSummary by CodeRabbit