Skip to content

Mdb 48544 mdb repl slot perms 17 - #150

Merged
reshke merged 1 commit into
MDB_17_11_prestablefrom
mdb-48544-mdb-repl-slot-perms-17
Oct 7, 2026
Merged

reshke merged 1 commit into
MDB_17_11_prestablefrom
mdb-48544-mdb-repl-slot-perms-17

Conversation

@reshke

@reshke reshke commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@reshke
reshke force-pushed the mdb-48544-mdb-repl-slot-perms-17 branch 2 times, most recently from 381da29 to 6551366 Compare October 7, 2026 06:10
@x4m

x4m commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Reviewed the updated 6551366. I found no issue with the new physical
StartReplication() check; it now preserves the same logical-only
mdb_replication behavior as #146.

The new TAP test still accepts unrelated failures as successful streaming
or logical slot creation: it only rejects one permission-error string.
Please check exit status 0 for creation and the expected CopyBoth response
for streaming, as discussed in #146. A psql timeout is not successful
streaming; psql exits when it receives CopyBoth.

t/113_mdb_repl_walsender_slot_perms.pl also needs an entry in
src/test/recovery/meson.build.

@reshke
reshke force-pushed the mdb-48544-mdb-repl-slot-perms-17 branch from 6551366 to 9b97b92 Compare October 7, 2026 07:14
@reshke
reshke merged commit 064f365 into MDB_17_11_prestable Oct 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants