Repository navigation
Guard error route-tagging against frozen rejections - #13
Merged
Merged
Conversation
Guard the advisorProvider assignment: tagging a frozen or non-extensible rejection would otherwise throw a TypeError that replaces the error the caller needs to see. Worst case is now an untagged row, never a masked failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line hardening for the PR #12 error tagging: guard the
advisorProviderassignment so a frozen or non-extensible rejection cannever throw a
TypeErrorthat replaces the original failure. Worst caseis now an untagged metrics row, never a masked error.
Verified by reading (no change needed):
withTimeoutrejects with anError, so timeout tagging works;switchAdvisorSessionModelfailurespropagate uncaught, so a failed pin aborts before generation and the tag
names the attempted route.
Verification
bun test: 363 pass, 0 fail;tsc --noEmitclean.Models: anthropic/claude-opus-5-5:xhigh, meta/muse-spark-1.3:max, anthropic/claude-fable-5-1:xhigh