Skip to content

chore(Popover): Include OUIAProps for Popover - #12572

Merged
thatblindgeye merged 2 commits into
patternfly:mainfrom
mshriver:popover-ouia
Aug 10, 2026
Merged

chore(Popover): Include OUIAProps for Popover#12572
thatblindgeye merged 2 commits into
patternfly:mainfrom
mshriver:popover-ouia

Conversation

@mshriver

@mshriver mshriver commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Add OUIA attribute support to Popover for better test automation. OUIA attributes are applied to the FocusTrap dialog root.

What:
Closes #12571

Snapshot tests commit
#12573
https://github.com/patternfly/patternfly-react/pull/12574/changes

Summary by CodeRabbit

  • New Features

    • Added OUIA support to the Popover component for improved automation and testing.
    • Popovers now expose component type, custom component IDs, and safety attributes.
    • Added configuration options for setting the OUIA ID and controlling the safety attribute, which defaults to enabled.
  • Documentation

    • Updated OUIA documentation to list Popover as a supported component.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c92478b4-f752-4753-872b-a8a6aa028807

📥 Commits

Reviewing files that changed from the base of the PR and between 0fee559 and 797339e.

⛔ Files ignored due to path filters (1)
  • packages/react-core/src/components/DatePicker/__tests__/__snapshots__/DatePicker.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (2)
  • packages/react-core/src/components/Popover/Popover.tsx
  • packages/react-core/src/helpers/OUIA/OUIA.md
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/react-core/src/helpers/OUIA/OUIA.md
  • packages/react-core/src/components/Popover/Popover.tsx

Walkthrough

Popover now accepts OUIA properties, applies generated OUIA attributes to its focus trap, tests those attributes, and lists Popover as OUIA-compliant.

Changes

Popover OUIA integration

Layer / File(s) Summary
OUIA contract and attribute wiring
packages/react-core/src/components/Popover/Popover.tsx
PopoverProps includes ouiaId and ouiaSafe. Popover generates OUIA props and applies them to FocusTrap.
OUIA validation and documentation
packages/react-core/src/components/Popover/__tests__/Popover.test.tsx, packages/react-core/src/helpers/OUIA/OUIA.md
Tests verify OUIA attributes. The OUIA component list includes Popover.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: kmcfaul, thatblindgeye, rebeccaalpert

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the Popover OUIA props change, which is the main purpose of the pull request.
Linked Issues check ✅ Passed The changes add OUIA props, attributes, tests, and documentation for Popover as required by issue #12571.
Out of Scope Changes check ✅ Passed The implementation, tests, and OUIA documentation changes are directly related to the linked issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rebeccaalpert rebeccaalpert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OUIA stuff looks good, but tests appear to be failing.

@rebeccaalpert rebeccaalpert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

mshriver and others added 2 commits August 10, 2026 10:57
Add OUIA attribute support to Popover for better test automation. OUIA
attributes are applied to the FocusTrap dialog root.

Co-authored-by: Cursor <cursoragent@cursor.com>
@rebeccaalpert

Copy link
Copy Markdown
Member

Rebased since we merged some other OUIA PRs.

@thatblindgeye
thatblindgeye merged commit 9a61fd1 into patternfly:main Aug 10, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Popover missing OUIA support

3 participants