chore(Popover): Include OUIAProps for Popover - #12572
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughPopover now accepts OUIA properties, applies generated OUIA attributes to its focus trap, tests those attributes, and lists Popover as OUIA-compliant. ChangesPopover OUIA integration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rebeccaalpert
left a comment
There was a problem hiding this comment.
OUIA stuff looks good, but tests appear to be failing.
Add OUIA attribute support to Popover for better test automation. OUIA attributes are applied to the FocusTrap dialog root. Co-authored-by: Cursor <cursoragent@cursor.com>
0fee559 to
797339e
Compare
|
Rebased since we merged some other OUIA PRs. |
Add OUIA attribute support to Popover for better test automation. OUIA attributes are applied to the FocusTrap dialog root.
What:
Closes #12571
Snapshot tests commit
#12573
https://github.com/patternfly/patternfly-react/pull/12574/changes
Summary by CodeRabbit
New Features
Documentation