Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #791.
ClipStepSizeControllercan accept a step ending just before a jump att1, then advance the next start across that jump. The requested-time save loop only checked the solver endpoint. The solve could therefore finish successfully with the finalSaveAt(ts=...)entry still set toinf.Consume requested saves through the accepted controller time. For times in the skipped interval, save the accepted state carried across the jump; within the actual solver step, use its interpolator. This follows the existing
SaveAt(steps=True)behavior and keeps the requested timestamp for custom save callbacks.The issue's rotation example now saves
[0.7316888, 0.68163913]at the terminal jump, close to[cos(0.75), sin(0.75)], with the same 108 accepted and 45 rejected steps as before. The broader controller/stage semantics proposed in #794 remain separate.Regressions cover real and complex single-precision states, forward and backward integration, complete analytic trajectories, real terminal Jacobians, a save callback that records its timestamp, and requested times immediately before/at/after an interior jump. Both terminal real-state cases include rejected steps.
Validation against main
e950aa2con local macOS CPU:uv run python -m testrunner: 1,003 passed, 0 failed, 0 skipped on each Python version, covering all 22 test modules, including slow tests.Fork CI was blocked before either job started by an account billing lock. No hosted test or accelerator result is claimed.