Skip to content

fix: requestAnimationFrame should ensure bind window - #1936

Closed
yhx9527 wants to merge 1 commit into
paperjs:developfrom
yhx9527:fix/raf-bind-window
Closed

yhx9527 wants to merge 1 commit into
paperjs:developfrom
yhx9527:fix/raf-bind-window

Conversation

@yhx9527

@yhx9527 yhx9527 commented Jul 21, 2021

Copy link
Copy Markdown

Description

nativeRequest should be bind wnidow, otherwise an error may occur

Related issues

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the JSHint rules (yarn run jshint passes)

@yhx9527
yhx9527 force-pushed the fix/raf-bind-window branch from ef86a76 to a93667d Compare July 21, 2021 10:42
@lehni

lehni commented Aug 16, 2022

Copy link
Copy Markdown
Member

Did an error actually occur? I've never seen this happening, so am really curious in what environment this is a problem, and what the error is?

@lehni

lehni commented Oct 18, 2026

Copy link
Copy Markdown
Member

Thanks! Calling requestAnimationFrame() without a this works in browsers, which fall back to the window, and we never got a reproduction of the error. Closing, but please reopen with the environment where it fails.

@lehni lehni closed this Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants