Repository navigation
Fix detection of Option + Space key on macOS - #1801
Closed
WesleyKapow wants to merge 1 commit into
Closed
WesleyKapow wants to merge 1 commit into
WesleyKapow wants to merge 1 commit into
Conversation
The Option + Space key combination on macOS results in a non-breaking space (U+00A0). This resulted in the modifiers not correctly detecting the release of the space key.
lehni
force-pushed
the
develop
branch
2 times, most recently
from
June 19, 2020 17:45
39b63a1 to
b90a711
Compare
lehni
force-pushed
the
develop
branch
3 times, most recently
from
June 22, 2020 13:18
4a6bf6f to
0f4afc5
Compare
2 tasks done
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Option + Space key combination on macOS results in a non-breaking
space (U+00A0). This resulted in the modifiers not correctly detecting
the release of the space key.
To reproduce on a mac:
event.modifiers.space: http://sketch.paperjs.org/#V/0.12.4/S/JcwxDoJAEEbhq0ymksTsATAegcpSLNZh0A3L/IRZaAh3B2P5vuJtbHFUrvkxaJEvX1nQ/boAOcAaLK4NVqU79YtJSbCLrmqloq01IoE5soaMz9/DiC71SWcPPkXR6tbafn7fs8ZhQrLiXD9f+wE=Expected:
false.Actual:
trueas the modifier is "stuck".