Repository navigation
fix: accept day-of-week 7 (Sunday) in the seconds and year cron forms - #263
Merged
potiuk merged 2 commits intoNov 1, 2026
Merged
Conversation
nikolauspschuetz
force-pushed
the
fix-dow7-second-year-forms
branch
from
August 16, 2026 16:11
f4e895c to
ee823d6
Compare
nikolauspschuetz
marked this pull request as ready for review
August 23, 2026 14:23
potiuk
approved these changes
Nov 1, 2026
potiuk
left a comment
Contributor
There was a problem hiding this comment.
LGTM — correct fix at the right layer. Dropping DOW_FIELD from the 6- and 7-field skip lists in value_alias lets 7 alias to Sunday like it does in the 5-field form. After the change, 5-7, 0-7, 7#2, L7, 7/2 and second_at_beginning all behave like 5-field. A side effect is that H(0-7) no longer fails for some hash ids. The new test fails on main, and CI is green.
- Heads-up: #281 edits the same line, adding
DAY_FIELDfor the 6-field form (#280). Whichever lands second needs a rebase. The end state should be[DAY_FIELD, MONTH_FIELD]for every form. - nit (optional): the test only covers a bare
7. One range (5-7) and one#/Lcase would also exercise thelow, high = value_alias(...)and nth paths.
This review was drafted by an AI-assisted tool and
confirmed by an croniter maintainer. The maintainer
approving this PR has read the findings and signed off. If
something feels off, please reply on the PR and a maintainer
will follow up.
Resolve CHANGELOG.rst conflict with pallets-eco#284 by keeping both entries. Generated-by: Claude Opus 5
potiuk
added a commit
to abhijeet117/croniter
that referenced
this pull request
Nov 1, 2026
Resolve CHANGELOG.rst conflict with pallets-eco#284 and pallets-eco#263 by keeping all entries. Generated-by: Claude Opus 5
potiuk
added a commit
to Harsh23Kashyap/croniter
that referenced
this pull request
Nov 1, 2026
Resolve the value_alias conflict with pallets-eco#263: the 6-field skip list is now [DAY_FIELD, MONTH_FIELD]. Generated-by: Claude Opus 5
potiuk
added a commit
to TrueFurina/croniter
that referenced
this pull request
Nov 1, 2026
Resolve the value_alias conflict with pallets-eco#263: the 6-field skip list is now [DAY_FIELD, MONTH_FIELD]. Generated-by: Claude Opus 5
potiuk
added a commit
to hdimer/croniter
that referenced
this pull request
Nov 1, 2026
Resolve conflicts with pallets-eco#284, pallets-eco#263 and pallets-eco#267 by keeping all entries. Generated-by: Claude Opus 5
potiuk
added a commit
to Raghuvardhan-Reddy78/croniter
that referenced
this pull request
Nov 1, 2026
Resolve conflicts with pallets-eco#284, pallets-eco#263 and pallets-eco#267 by keeping all entries. Generated-by: Claude Opus 5
potiuk
added a commit
to abhijeet117/croniter
that referenced
this pull request
Nov 1, 2026
Resolve conflicts with pallets-eco#284, pallets-eco#263 and pallets-eco#267 by keeping all entries. Generated-by: Claude Opus 5
potiuk
added a commit
to Raghuvardhan-Reddy78/croniter
that referenced
this pull request
Nov 1, 2026
Resolve conflicts with pallets-eco#284, pallets-eco#263 and pallets-eco#267 by keeping all entries. Generated-by: Claude Opus 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
7is a standard alias for Sunday (0), and croniter accepts it in the classic 5-field form.value_aliasskipped the7 -> 0conversion in the 6-field (seconds) and 7-field (year) forms, so7was rejected there as out of range:The guard is there to keep rejecting
0as a day/month in those forms; day-of-week was swept into it. Dropping day-of-week from the two branches makes7 -> Sundaywork in every form while leaving the month/day0rejection unchanged. Regression test added; full suite green.