Skip to content

Fix ZEUS2 Grafana link routing by detecting run_name pattern - #80

Merged
Harshith-umesh merged 1 commit into
openshift-psap:mainfrom
aas008:fix/zeus2-run-name-routing
Aug 25, 2026
Merged

Harshith-umesh merged 1 commit into
openshift-psap:mainfrom
aas008:fix/zeus2-run-name-routing

Conversation

@aas008

@aas008 aas008 commented Aug 13, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

ZEUS2 runs store accelerator='H200' in the CSV but use H200-zeus2- prefix in run names. The existing code matches on accelerator == 'H200' before checking the H200_ZEUS2 mapping, routing ZEUS2 runs to H200_NEW/H200_OLD dashboards instead of the correct ZEUS2 dashboard.

Solution

Add _is_zeus2_run() helper function that checks for H200-ZEUS2- or H200_ZEUS2- prefix in run names, and check this pattern before the generic H200 accelerator check. This matches the existing pattern for HERA and HERA2 clusters.

Testing

ZEUS2 runs with H200-zeus2- prefix in run_name will now route to:

  • vLLM: d35f19c8f56250/vllm-2b-dcgm-metrics-psap-zeus-syd
  • SGLang: sglang-dcgm-metrics-psap-rhaiis-h200 (shared H200 dashboard)

Summary by CodeRabbit

  • New Features
    • Added support for detecting H200 ZEUS2 runs.
    • Metrics links for these runs now route to the appropriate Grafana dashboard.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2b784ec6-1060-4115-9098-41a9a937d4b1

📥 Commits

Reviewing files that changed from the base of the PR and between 43d261d and 0d27c33.

📒 Files selected for processing (1)
  • dashboard.py

📝 Walkthrough

Walkthrough

The dashboard detects H200 ZEUS2 runs with hyphenated or underscored prefixes and routes their Grafana links to the H200_ZEUS2 configuration before generic H200 routing.

Changes

H200 ZEUS2 dashboard routing

Layer / File(s) Summary
ZEUS2 detection and Grafana routing
dashboard.py
Adds _is_zeus2_run for supported run prefixes. ZEUS2 runs now use the H200_ZEUS2 Grafana dashboard configuration before date-based H200 routing.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Mergeability Score: ⚪ Minimal · up to 0d27c

This localized routing fix is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

Possibly related PRs

Suggested reviewers: harshith-umesh

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the ZEUS2 Grafana link routing fix through run name pattern detection.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@43d261d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
dashboard.py 0.00% 7 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@          Coverage Diff           @@
##             main     #80   +/-   ##
======================================
  Coverage        ?   3.46%           
======================================
  Files           ?       8           
  Lines           ?    8376           
  Branches        ?       0           
======================================
  Hits            ?     290           
  Misses          ?    8086           
  Partials        ?       0           
Flag Coverage Δ
unittests 3.46% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

The H200_ZEUS2 cluster stores accelerator='H200' in the CSV but uses
'H200-zeus2-' prefix in run names. Without explicit run_name detection,
the generic 'accelerator == H200' check routes ZEUS2 runs to the wrong
dashboard (H200_NEW/H200_OLD).

Add _is_zeus2_run() helper and check run_name pattern before the generic
H200 accelerator check, matching the existing HERA/HERA2 pattern.
@aas008
aas008 force-pushed the fix/zeus2-run-name-routing branch from 0d27c33 to 7f8f4bf Compare August 13, 2026 17:12
@Harshith-umesh
Harshith-umesh merged commit 115184d into openshift-psap:main Aug 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants