Fix ZEUS2 Grafana link routing by detecting run_name pattern - #80
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe dashboard detects H200 ZEUS2 runs with hyphenated or underscored prefixes and routes their Grafana links to the ChangesH200 ZEUS2 dashboard routing
Estimated code review effort: 1 (Trivial) | ~5 minutes Mergeability Score: ⚪ Minimal · up to This localized routing fix is merge-ready after normal checks and review; no actionable merge-blocking risk remains. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
======================================
Coverage ? 3.46%
======================================
Files ? 8
Lines ? 8376
Branches ? 0
======================================
Hits ? 290
Misses ? 8086
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The H200_ZEUS2 cluster stores accelerator='H200' in the CSV but uses 'H200-zeus2-' prefix in run names. Without explicit run_name detection, the generic 'accelerator == H200' check routes ZEUS2 runs to the wrong dashboard (H200_NEW/H200_OLD). Add _is_zeus2_run() helper and check run_name pattern before the generic H200 accelerator check, matching the existing HERA/HERA2 pattern.
0d27c33 to
7f8f4bf
Compare
Problem
ZEUS2 runs store
accelerator='H200'in the CSV but useH200-zeus2-prefix in run names. The existing code matches onaccelerator == 'H200'before checking the H200_ZEUS2 mapping, routing ZEUS2 runs to H200_NEW/H200_OLD dashboards instead of the correct ZEUS2 dashboard.Solution
Add
_is_zeus2_run()helper function that checks forH200-ZEUS2-orH200_ZEUS2-prefix in run names, and check this pattern before the generic H200 accelerator check. This matches the existing pattern for HERA and HERA2 clusters.Testing
ZEUS2 runs with
H200-zeus2-prefix in run_name will now route to:d35f19c8f56250/vllm-2b-dcgm-metrics-psap-zeus-sydsglang-dcgm-metrics-psap-rhaiis-h200(shared H200 dashboard)Summary by CodeRabbit