Repository navigation
Fix dashboard errors and add B200_PIRATE cluster support - #78
Merged
Harshith-umesh merged 2 commits intoAug 31, 2026
Merged
Harshith-umesh merged 2 commits into
Harshith-umesh merged 2 commits into
Conversation
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📝 WalkthroughWalkthrough
ChangesDashboard data and links
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
======================================
Coverage ? 3.49%
======================================
Files ? 8
Lines ? 8306
Branches ? 0
======================================
Hits ? 290
Misses ? 8016
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@dashboard.py`:
- Around line 341-349: Normalize the critical fields in the dataframe filtering
block before dropna: strip whitespace from accelerator, model, and version, then
convert empty strings to pd.NA so blank values are removed. Preserve the
existing dropped-row warning and add regression coverage for whitespace-only and
empty critical fields.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Member
|
needs rebase |
Fixes dashboard crash when CSV contains rows with empty accelerator, model, or version fields. The error manifested as: TypeError: '<' not supported between instances of 'float' and 'str' Root cause: pandas reads empty CSV cells as np.nan (float). When .str.strip() is called, NaN values remain as floats while valid values become strings, creating mixed types that sorted() cannot compare. Solution: Drop rows with missing critical fields during data load. These rows indicate upstream data quality issues (Model Furnace should always provide accelerator/model/version). Added logging to track how many malformed rows are filtered out. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Adds B200 PIRATE cluster dashboard configuration to enable Grafana metrics links for runs on the B200_PIRATE cluster. Dashboard: vllm-2b-dcgm-metrics-b200-pirate Dashboard ID: b200-pirate-vllm-dcgm Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
aas008
force-pushed
the
fix/dashboard-errors-and-pirate-cluster
branch
from
August 31, 2026 13:46
6711020 to
76c4667
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes critical dashboard errors and adds B200_PIRATE cluster Grafana dashboard support.
Changes
Fix TypeError on missing accelerator/model/version values
accelerator,model, orversionfields during data loadTypeError: '<' not supported between instances of 'float' and 'str'np.nan(float), creating mixed types when.str.strip()is calledAdd B200_PIRATE cluster Grafana dashboard support
B200_PIRATEtoGRAFANA_DASHBOARDSconfigurationb200-pirate-vllm-dcgmvllm-2b-dcgm-metrics-b200-pirateTesting
Related Issues
Fixes dashboard crash from malformed CSV data with missing critical fields.
🤖 Generated with Claude Code
Summary by CodeRabbit