Skip to content

fix(rhaiis): skip PyTorch profiling for Profile 5 - #278

Merged
Harshith-umesh merged 2 commits into
openshift-psap:mainfrom
Harshith-umesh:codex/profile5-profiler-exclusion
Sep 28, 2026
Merged

Harshith-umesh merged 2 commits into
openshift-psap:mainfrom
Harshith-umesh:codex/profile5-profiler-exclusion

Conversation

@Harshith-umesh

@Harshith-umesh Harshith-umesh commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Exclude profile5 from the PyTorch profiler phase even when job-level overrides enable profiling.
  • Preserve the existing no-warmup behavior while a profiler run is active, and also skip Profile 5 warmup when profiling was requested but it is excluded from the profiler pass.
  • Keep Profile 5 on the normal benchmark path; its benchmark setting remains authoritative.
  • Add regression tests for profiler and warmup workload selection.

Validation

  • ruff check passed.
  • ruff format --check passed.
  • Test suite not run locally.

@openshift-ci

openshift-ci Bot commented Sep 28, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mml-coder for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Sep 28, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 75176410-8469-4e91-96a8-5eca74326941

📥 Commits

Reviewing files that changed from the base of the PR and between 5be9c79 and 0439020.

📒 Files selected for processing (2)
  • projects/rhaiis/orchestration/test_phase.py
  • projects/rhaiis/tests/test_profiler_selection.py
 ______________________________________________________________________________________________________
< What one programmer can do in one month, two programmers can do in two months. - Frederick P. Brooks >
 ------------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Harshith-umesh
Harshith-umesh merged commit 96eaefd into openshift-psap:main Sep 28, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant