Repository navigation
Conversation
🍎 MacOS DMG universal buildsDownload a MacOS DMG universal build of this PR for testing. 📱 Android buildsDownload an Android arm64 build of this PR for testing. Other Android architectures🐧 Linux AppImage buildsDownload a Linux AppImage build of this PR for testing. |
|
The current Poppler failure first appeared in the Windows ARM job that started November 14, 2026 at 11:33 PM EST (failed job). Its log shows the same C2338: can't delete an incomplete type error. The runner image changed between the last passing and first failing Windows ARM jobs:
|
| if ( mSocket->state() == QAbstractSocket::UnconnectedState ) | ||
| { | ||
| setSocketState( QAbstractSocket::UnconnectedState ); | ||
| } |
There was a problem hiding this comment.
Why is this needed? We already have a signal plugged into the mSocket that updates the socket state.
| property real progressValue: 0.0 | ||
| property bool showProgress: false | ||
| property color progressColor: QfTheme.mainColor | ||
| property color progressColor: button.color |
There was a problem hiding this comment.
Please take this out of the PR, it's a subjective change we could argue over in a separate channel :)
| if (name === positioningDeviceSettings.generateName()) | ||
| positioningDeviceSettings.name = ''; |
There was a problem hiding this comment.
What is this change doing? Doesn't feel connected to what is being addressed in the PR.
General formatting note: we require { } braces for newly-added code.
As a TCP Connection, I need a way to cancel a connection that is in flight before it is connected. Currently there is no way for a connection to be canceled once it is started, not even if deleted.
Added "Cancel" action to TCP connection.
Changed moving border's color from QField green to text color so you can see it. Tthis way it matches text color regardless of in light or dark mode
Added test to validate cancel action