Skip to content

Positioning Device - TCP connection cancel - #8217

Open
orrious wants to merge 3 commits into
opengisch:masterfrom
orrious:feature/positioning_device_cancel
Open

orrious wants to merge 3 commits into
opengisch:masterfrom
orrious:feature/positioning_device_cancel

Conversation

@orrious

@orrious orrious commented Nov 17, 2026

Copy link
Copy Markdown

As a TCP Connection, I need a way to cancel a connection that is in flight before it is connected. Currently there is no way for a connection to be canceled once it is started, not even if deleted.

Added "Cancel" action to TCP connection.

Changed moving border's color from QField green to text color so you can see it. Tthis way it matches text color regardless of in light or dark mode

Added test to validate cancel action

@qfield-fairy

qfield-fairy commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

🍎 MacOS DMG universal builds

Download a MacOS DMG universal build of this PR for testing.
(Built from commit 91855b8)

📱 Android builds

Download an Android arm64 build of this PR for testing.
(Built from commit 91855b8)

Other Android architectures

🐧 Linux AppImage builds

Download a Linux AppImage build of this PR for testing.
(Built from commit 91855b8)

@orrious

orrious commented Nov 17, 2026

Copy link
Copy Markdown
Author

The current Poppler failure first appeared in the Windows ARM job that started November 14, 2026 at 11:33 PM EST (failed job). Its log shows the same C2338: can't delete an incomplete type error.

The runner image changed between the last passing and first failing Windows ARM jobs:

  • Last pass
    MSVC toolset: 14.51.36231
    Poppler 26.4.0: Restored from cache
  • First failure
    MSVC toolset: 14.52.37025
    Poppler 26.4.0: Cache entry unavailable; built from source

@nirvn nirvn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings @orrious , nice to meet you.

Adding some comments to this first PR of yours. I'm sure we can push this through the finish line :)

Comment on lines +82 to +85
if ( mSocket->state() == QAbstractSocket::UnconnectedState )
{
setSocketState( QAbstractSocket::UnconnectedState );
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? We already have a signal plugged into the mSocket that updates the socket state.

Comment thread src/gui/qml/QfButton.qml
property real progressValue: 0.0
property bool showProgress: false
property color progressColor: QfTheme.mainColor
property color progressColor: button.color

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take this out of the PR, it's a subjective change we could argue over in a separate channel :)

Comment on lines +1366 to +1367
if (name === positioningDeviceSettings.generateName())
positioningDeviceSettings.name = '';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this change doing? Doesn't feel connected to what is being addressed in the PR.

General formatting note: we require { } braces for newly-added code.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants