powerIsOn in FruDevice will not set false

[diligentzi]

As stated, powerIsOn is not set to false, which leads to an inaccurate power state. It also triggers a rescan when the power is off.

[pointbazaar]

It also triggers a rescan when the power is off.

Why is this a problem? Can we never do a bus scan when the host is off?

FruDevice scans for IPMI fru eeproms which contain inventory information (which should probably be available in all power states)

If those sit on a bus that's only available when the host is powered, isn't that a hw design problem?

[pointbazaar]

@diligentzi can you re-phrase your issue in terms of the actual issue you are experiencing on your platform?

[diligentzi]

I ran into a real issue where the powerIsOn state was inaccurate, which caused logic errors when it was used elsewhere. A rescan can also be done when the power is off, but the original intent of this code seems to be that a rescan is only needed when the power is on.

@diligentzi can you re-phrase your issue in terms of the actual issue you are experiencing on your platform?

[pointbazaar]

I ran into a real issue where the powerIsOn state was inaccurate, which caused logic errors when it was used elsewhere.

Which platform are you using?
What issue did you encounter? I am looking for a real issue where something on your platform was not working how you expected.

Examples of what i am talking about

• fru device drops information from an eeprom that's still present
• fru device exposes information from an eeprom that's no longer on the bus (hw was removed)
• fru device crash
• useless re-scan or double scan
• memory leaks
• missing property on D-Bus
• ...

I am not talking about conceptual issues or interpreting the intention of the code. The code is wrong anyways since a singular on/off powerstate does not cover all hardware (e.g. blade server). It was wrong from the beginning probably.

A rescan can also be done when the power is off, but the original intent of this code seems to be that a rescan is only needed when the power is on.

That's your interpretation. And as outlined above, there is no singular on/off anymore.

There are lots of cases where ReScan is triggered externally due to use-cases FruDevice alone cannot cover

https://github.com/search?q=org%3Aopenbmc+%2F%28%3F-i%29ReScan%2F&type=code