Repository navigation
chore(api): document decision choice constraints - #832
Conversation
Castiron-Internal-PR: openai/openai-ruby-internal#220 Castiron-Source-SHA: d742141cf5252ea89c2b6dc229a626154d97be94 Castiron-Public-Base-SHA: 983a531
Castiron custom codeEvaluated main: ✅ No new custom-code files detected. 85 mixed files remain; 0 existing customizations changed; 1 customizations removed; 3 generated baselines changed. Compared
83 existing customizations unchanged
43 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 38111933359 --repo openai/openai-ruby \
--name castiron-custom-code-38111933359-1 --dir /tmp/castiron-custom-code-38111933359-1
git apply --stat /tmp/castiron-custom-code-38111933359-1/custom-code.patch
cat /tmp/castiron-custom-code-38111933359-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 983a5314d9dba5f3539b9e81220b185ee123b0d5 14e2efb5dbb2ad93765e1154f7a31692dd9be721
python3 scripts/castiron/custom_code_report.py report \
--base 983a5314d9dba5f3539b9e81220b185ee123b0d5 \
--head 14e2efb5dbb2ad93765e1154f7a31692dd9be721 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-14e2efb5dbb2
cat /tmp/castiron-custom-code-14e2efb5dbb2/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed all five changed files at 14e2efb5dbb2ad93765e1154f7a31692dd9be721. No actionable findings.
The full schema comparison adds only the choice description: provide 2–255 choices, with each choice unique. Ruby, RBI and RBS document the same rule. Executable code, type signatures and schema constraints are unchanged. The public generator snapshot resolves and has no .github/workflows directory.
Current-head CI passed. The external OkTest run also passed for this head and base. This was a source-only review; I ran no repository tests, builds or generation.
Summary
Clarifies the number and uniqueness requirements for decision choices.
Changes