Skip to content

chore(api): document decision choice constraints - #832

Merged
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-220
Oct 11, 2026
Merged

jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-220

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Contributor

Summary

Clarifies the number and uniqueness requirements for decision choices.

Changes

  • Document that choice questions require between 2 and 255 unique choices.

Castiron-Internal-PR: openai/openai-ruby-internal#220
Castiron-Source-SHA: d742141cf5252ea89c2b6dc229a626154d97be94
Castiron-Public-Base-SHA: 983a531
@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Castiron custom code

Evaluated main: 983a5314d9dba5f3539b9e81220b185ee123b0d5.

✅ No new custom-code files detected.

85 mixed files remain; 0 existing customizations changed; 1 customizations removed; 3 generated baselines changed.

Compared 983a5314d9db → 14e2efb5dbb2. Generated baselines verified.

File Result Current custom patch
lib/openai/models/beta/agents/vault_status_filter.rb Generated baseline changed +3 / −1
lib/openai/resources/containers/files.rb Generated baseline changed None
rbi/openai/models/beta/agents/vault_status_filter.rbi Generated baseline changed +3 / −1
83 existing customizations unchanged
  • lib/openai.rb
  • lib/openai/client.rb
  • lib/openai/models/audio/transcription_create_response.rb
  • lib/openai/models/audio/translation_create_response.rb
  • lib/openai/models/chat/chat_completion_message.rb
  • lib/openai/models/chat/chat_completion_message_function_tool_call.rb
  • lib/openai/models/chat/completion_create_params.rb
  • lib/openai/models/image_edit_completed_event.rb
  • lib/openai/models/image_edit_partial_image_event.rb
  • lib/openai/models/image_gen_completed_event.rb
  • lib/openai/models/image_gen_partial_image_event.rb
  • lib/openai/models/images_response.rb
  • lib/openai/models/response_format_json_schema.rb
  • lib/openai/models/responses/function_tool.rb
  • lib/openai/models/responses/response.rb
  • lib/openai/models/responses/response_create_params.rb
  • lib/openai/models/responses/response_format_text_config.rb
  • lib/openai/models/responses/response_format_text_json_schema_config.rb
  • lib/openai/models/responses/response_function_tool_call.rb
  • lib/openai/models/responses/response_function_web_search.rb
  • lib/openai/models/responses/response_output_text.rb
  • lib/openai/models/responses/tool.rb
  • lib/openai/models/webhooks/webhook_endpoint_with_secret.rb
  • lib/openai/resources/audio/transcriptions.rb
  • lib/openai/resources/audio/translations.rb
  • lib/openai/resources/beta/agents/environments/files.rb
  • lib/openai/resources/beta/agents/sessions.rb
  • lib/openai/resources/beta/agents/sessions/artifacts.rb
  • lib/openai/resources/beta/threads.rb
  • lib/openai/resources/chat/completions.rb
  • lib/openai/resources/files.rb
  • lib/openai/resources/responses.rb
  • lib/openai/resources/vector_stores/file_batches.rb
  • lib/openai/resources/vector_stores/files.rb
  • lib/openai/resources/webhooks.rb
  • rbi/openai/client.rbi
  • rbi/openai/models/audio/transcription_create_response.rbi
  • rbi/openai/models/audio/translation_create_response.rbi
  • rbi/openai/models/chat/chat_completion_message.rbi
  • rbi/openai/models/chat/chat_completion_message_function_tool_call.rbi

43 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 38111933359 --repo openai/openai-ruby \
  --name castiron-custom-code-38111933359-1 --dir /tmp/castiron-custom-code-38111933359-1
git apply --stat /tmp/castiron-custom-code-38111933359-1/custom-code.patch
cat /tmp/castiron-custom-code-38111933359-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 983a5314d9dba5f3539b9e81220b185ee123b0d5 14e2efb5dbb2ad93765e1154f7a31692dd9be721
python3 scripts/castiron/custom_code_report.py report \
  --base 983a5314d9dba5f3539b9e81220b185ee123b0d5 \
  --head 14e2efb5dbb2ad93765e1154f7a31692dd9be721 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-14e2efb5dbb2
cat /tmp/castiron-custom-code-14e2efb5dbb2/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@jbeckwith-oai
jbeckwith-oai marked this pull request as ready for review October 11, 2026 04:32
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 11, 2026 04:32
@openai-sdks

openai-sdks Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 5.763s for Ruby SDK PR #832.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 198ms
tests/chat-completions-create.test.ts ✅ Passed 126ms
tests/chat-completions-stream.test.ts ✅ Passed 148ms
tests/files-content-binary.test.ts ✅ Passed 103ms
tests/files-create-multipart.test.ts ✅ Passed 123ms
tests/files-list-pagination.test.ts ✅ Passed 127ms
tests/initialize-config.test.ts ✅ Passed 77ms
tests/instance-isolation.test.ts ✅ Passed 104ms
tests/models-list.test.ts ✅ Passed 122ms
tests/responses-background-lifecycle.test.ts ✅ Passed 104ms
tests/responses-body-method-errors.test.ts ✅ Passed 262ms
tests/responses-cancel-timeout.test.ts ✅ Passed 195ms
tests/responses-cancel.test.ts ✅ Passed 97ms
tests/responses-compact-retries.test.ts ✅ Passed 111ms
tests/responses-compact.test.ts ✅ Passed 183ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 131ms
tests/responses-create-advanced.test.ts ✅ Passed 158ms
tests/responses-create-disconnect.test.ts ✅ Passed 118ms
tests/responses-create-errors.test.ts ✅ Passed 223ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 130ms
tests/responses-create-retries.test.ts ✅ Passed 116ms
tests/responses-create-stream-failures.test.ts ✅ Passed 141ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 220ms
tests/responses-create-stream-wire.test.ts ✅ Passed 720ms
tests/responses-create-stream.test.ts ✅ Passed 96ms
tests/responses-create-terminal-states.test.ts ✅ Passed 210ms
tests/responses-create-timeout.test.ts ✅ Passed 219ms
tests/responses-create.test.ts ✅ Passed 98ms
tests/responses-delete.test.ts ✅ Passed 103ms
tests/responses-input-items-errors.test.ts ✅ Passed 137ms
tests/responses-input-items-list.test.ts ✅ Passed 151ms
tests/responses-input-items-options.test.ts ✅ Passed 127ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 252ms
tests/responses-input-tokens-count.test.ts ✅ Passed 149ms
tests/responses-malformed-inputs.test.ts ✅ Passed 790ms
tests/responses-not-found-errors.test.ts ✅ Passed 248ms
tests/responses-parse.test.ts ✅ Passed 122ms
tests/responses-retrieve-retries.test.ts ✅ Passed 123ms
tests/responses-retrieve.test.ts ✅ Passed 131ms
tests/responses-stored-method-errors.test.ts ✅ Passed 585ms
tests/retry-behavior.test.ts ✅ Passed 2.992s
tests/sdk-error-shape.test.ts ✅ Passed 321ms

View OkTest run #38111916662

SDK merge (aeef9e4fdc4b) · head (14e2efb5dbb2) · base (983a5314d9db) · OkTest (59813f410948)

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T04:34:07.398741Z 14e2efb Draft marked ready
🔒 Security Review ✅ Completed 2026-10-11T04:34:59.122961Z 14e2efb Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all five changed files at 14e2efb5dbb2ad93765e1154f7a31692dd9be721. No actionable findings.

The full schema comparison adds only the choice description: provide 2–255 choices, with each choice unique. Ruby, RBI and RBS document the same rule. Executable code, type signatures and schema constraints are unchanged. The public generator snapshot resolves and has no .github/workflows directory.

Current-head CI passed. The external OkTest run also passed for this head and base. This was a source-only review; I ran no repository tests, builds or generation.

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 11, 2026
Merged via the queue into main with commit c15703a Oct 11, 2026
24 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the castiron/promotions/pr-220 branch October 11, 2026 05:02
@openai-sdks openai-sdks Bot mentioned this pull request Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants