Repository navigation
Make command help complete and consistent - #384
Conversation
Castiron custom codeEvaluated main: ✅ No new custom-code files detected. 2 mixed files remain; 0 existing customizations changed. Compared 2 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 37814988099 --repo openai/openai-cli \
--name castiron-custom-code-37814988099-1 --dir /tmp/castiron-custom-code-37814988099-1
git apply --stat /tmp/castiron-custom-code-37814988099-1/custom-code.patch
cat /tmp/castiron-custom-code-37814988099-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin babc0e001e2def850d66303c08330ee704e6886c 1f6c0a8bb87eff90526b39b27152aab411ac28ad
python3 scripts/castiron/custom_code_report.py report \
--base babc0e001e2def850d66303c08330ee704e6886c \
--head 1f6c0a8bb87eff90526b39b27152aab411ac28ad --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-1f6c0a8bb87e
cat /tmp/castiron-custom-code-1f6c0a8bb87e/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
|
@codex review Please review commit |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed 1f6c0a8bb87eff90526b39b27152aab411ac28ad. No actionable findings.
I checked help routing, legacy --all, flag and positional-input descriptions, terminal text, completion behavior, and parser-error guidance. The changes keep request handling separate from help presentation.
Source-only review; I did not run repository tests or builds. Hosted tests, build, lint, and help checks on macOS, Ubuntu, and Windows passed for this head.
Command help currently shows a short page and requires
help --allfor the full reference. This gives every help entrypoint the same complete command page. The layout follows gcloud's full reference, with concrete syntax and clearer flag descriptions.What changes
-h,--help, andhelpshow the same page, including after valid options and through nested command paths.help --allprints migration guidance before the same page. Command-ownedimages models --allstays available.Commands
No new commands or flags. These help forms now show identical content:
Help remains offline. Required-input notes preserve existing positional, flag, JSON, and YAML input contracts. Request defaults and output modes are unchanged.
Code
internal/clihelpowns help routing, synopses, flag references, and terminal prose.pkg/customsupplies presentation metadata and parser-error guidance. Generated path-input metadata follows existing command clones without changing flags or actions.The completion change preserves manually typed legacy help flags while hiding them from suggestions. Generated API sources, dependencies, and
main.goare unchanged.Tested
Merged pinned main
d32b3aeinto the reviewed Help branch. The merge preservesc9817b1and imports the exact upstream voice contract.Fresh macOS validation at
fc944dapassed 1,166 public test/subtest checks, including required native Bash/zsh execution. Internal help/request-flag checks passed 540 records. Custom integration passed 191 records; voice contracts passed 29. These runs had no failures or skips.The owned voice-type read cancellation test passed under the race detector. All package tests compiled. The candidate build,
go vet ./..., andgo mod verifypassed.Independent adversarial review passed 584 assertions across 527 processes. It covered complete-help equality, native copied commands, parser privacy, multipart inputs, and the merged voice contract.
Generated sources, schemas, and generation metadata match pinned main exactly. Main's trusted custom-code checker passed at 21/1,000 lines.
CI and native help checks passed at
fc944da; conditional jobs were skipped.The naming-only follow-up preserves every test assertion. It passed 11 focused test records, and the existing help CI selector discovers all four renamed tests. CI is rerunning at
1f6c0a8. The broader manual platform campaign remains deferred.Demo
Real binaries on macOS, recorded at 90 and 56 columns. Before is main
da762ff; after is this PR. Captures made no API requests. Images show labeled excerpts; the recorder also retains complete stdout. Fresh comparison checks confirm all four recorded help pages remain byte-identical after the pinned-main merge.Before:
After:
Recording recipe