Skip to content

fix(config): allow extended effort with Claude CLI - #635

Merged
zzwong merged 2 commits into
mainfrom
zzwong/claude-cli-max-effort
Sep 30, 2026
Merged

zzwong merged 2 commits into
mainfrom
zzwong/claude-cli-max-effort

Conversation

@zzwong

@zzwong zzwong commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Claude CLI accepts xhigh and max effort for supported models, but CR rejected both before starting a review because its runtime capability limit stopped at high. This change raises only the Claude CLI limit; the Anthropic API adapter remains capped at high.

What changed

  • Allow xhigh and max through configuration, stage resolution, benchmark validation, and review invocation for the Claude CLI runtime.
  • Cover forwarding --effort max to the Claude subprocess and preserve rejection of extended effort for the Anthropic API adapter.
  • Update user-facing effort documentation to match the current runtime limits and clarify that the installed CLI and selected model determine effective support.

Verification

  • go test ./... — 3,325 tests passed across 71 packages.
  • GOTOOLCHAIN=go1.26.3 make lint — no issues. The installed linter was built with Go 1.26.3; running it under the machine's default Go 1.27.1 caused an unrelated standard-library typecheck error.
  • git diff --check — passed.

monit-reviewer
monit-reviewer previously approved these changes Sep 29, 2026

@monit-reviewer monit-reviewer left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated PR Review

Reviewed commit: 920ca7108e3e
Profile: open-cli-collective-review - Posting as: monit-reviewer

Summary

Reviewer Findings
go:implementation-tests 0
policies:conventions 0

Reviewer Coverage

  • go:implementation-tests — complete (broad); inspected 8 assigned files (11 inspected across reviewers): internal/benchmark/suite_test.go, internal/cmd/reviewcmd/reviewcmd_test.go, internal/config/config.go, internal/config/config_effort_test.go, internal/config/config_max_effort_test.go, internal/llmadapters/subprocess_test.go, internal/pipeline/pipeline_test.go, internal/stagemodel/resolver_test.go; skipped: none; constraints: Static review only; the available CR tools cannot execute Go tests.
  • policies:conventions — complete (broad); inspected 5 assigned files (11 inspected across reviewers): BENCHMARKING.md, README.md, docs/init-config-surface.md, internal/cmd/reviewcmd/reviewcmd_test.go, internal/config/config.go; skipped: none; constraints: Review was limited to repository-visible conventions; canonical shared CLI standards were not present in the provided context.
Inspected files (11)
  • BENCHMARKING.md
  • README.md
  • docs/init-config-surface.md
  • internal/benchmark/suite_test.go
  • internal/cmd/reviewcmd/reviewcmd_test.go
  • internal/config/config.go
  • internal/config/config_effort_test.go
  • internal/config/config_max_effort_test.go
  • internal/llmadapters/subprocess_test.go
  • internal/pipeline/pipeline_test.go
  • internal/stagemodel/resolver_test.go

0 PR discussion threads considered. 0 summarized; 0 resolved.


Completed in 1m 32s | $0.04 | openai-codex/gpt-5.6-terra | cr 0.10.316
Field Value
Model openai-codex/gpt-5.6-terra
Reviewers go:implementation-tests, policies:conventions
Engine pi_rpc · openai-codex/gpt-5.6-terra
Reviewed by cr · monit-reviewer
Duration 1m 32s wall · 1m 59s compute
Cost $0.04
Tokens 11.0k in / 891 out

Per-workstream usage

  • orchestrator-selection — openai-codex/gpt-5.6-terra
    • In: 6.2k
    • Out: 421
    • Cache read: 0
    • Cache create: 0
    • Cost: $0.02
    • Duration: 9s
  • go:implementation-tests — openai-codex/gpt-5.6-terra
    • In: 1.9k
    • Out: 234
    • Cache read: 30.2k
    • Cache create: 0
    • Cost: $0.01
    • Duration: 1m 09s
  • policies:conventions — openai-codex/gpt-5.6-terra
    • In: 1.6k
    • Out: 199
    • Cache read: 8.7k
    • Cache create: 0
    • Cost: $0.01
    • Duration: 37s
  • orchestrator-rollup — openai-codex/gpt-5.6-terra
    • In: 1.3k
    • Out: 37
    • Cache read: 2.8k
    • Cache create: 0
    • Cost: $0.00
    • Duration: 3s

@zzwong zzwong changed the title Fix extended effort support for Claude CLI fix(config): allow extended effort with Claude CLI Sep 29, 2026
@zzwong
zzwong marked this pull request as ready for review September 29, 2026 23:25
@zzwong
zzwong marked this pull request as draft September 29, 2026 23:26

@monit-reviewer monit-reviewer left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated PR Review

Reviewed commit: fdd87491be20
Profile: open-cli-collective-review - Posting as: monit-reviewer

Summary

Reviewer Findings
go:implementation-tests 0
policies:conventions 0

Reviewer Coverage

  • go:implementation-tests — complete (constrained); inspected 8 assigned files (11 inspected across reviewers): internal/benchmark/suite_test.go, internal/cmd/reviewcmd/reviewcmd_test.go, internal/config/config.go, internal/config/config_effort_test.go, internal/config/config_max_effort_test.go, internal/llmadapters/subprocess_test.go, internal/pipeline/pipeline_test.go, internal/stagemodel/resolver_test.go; skipped: none; constraints: Review scoped to the assigned changed Go implementation and test files.
  • policies:conventions — complete (constrained); inspected 5 assigned files (11 inspected across reviewers): BENCHMARKING.md, README.md, docs/init-config-surface.md, internal/cmd/reviewcmd/reviewcmd_test.go, internal/config/config.go; skipped: none; constraints: none
Inspected files (11)
  • BENCHMARKING.md
  • README.md
  • docs/init-config-surface.md
  • internal/benchmark/suite_test.go
  • internal/cmd/reviewcmd/reviewcmd_test.go
  • internal/config/config.go
  • internal/config/config_effort_test.go
  • internal/config/config_max_effort_test.go
  • internal/llmadapters/subprocess_test.go
  • internal/pipeline/pipeline_test.go
  • internal/stagemodel/resolver_test.go

0 PR discussion threads considered. 0 summarized; 0 resolved.


Completed in 59s | $0.04 | openai-codex/gpt-5.6-terra | cr 0.10.316
Field Value
Model openai-codex/gpt-5.6-terra
Reviewers go:implementation-tests, policies:conventions
Engine pi_rpc · openai-codex/gpt-5.6-terra
Reviewed by cr · monit-reviewer
Duration 59s wall · 1m 27s compute
Cost $0.04
Tokens 14.0k in / 763 out

Per-workstream usage

  • go:implementation-tests — openai-codex/gpt-5.6-terra
    • In: 2.5k
    • Out: 512
    • Cache read: 9.7k
    • Cache create: 0
    • Cost: $0.01
    • Duration: 42s
  • policies:conventions — openai-codex/gpt-5.6-terra
    • In: 10.2k
    • Out: 214
    • Cache read: 12.8k
    • Cache create: 0
    • Cost: $0.03
    • Duration: 42s
  • orchestrator-rollup — openai-codex/gpt-5.6-terra
    • In: 1.3k
    • Out: 37
    • Cache read: 2.8k
    • Cache create: 0
    • Cost: $0.00
    • Duration: 3s

@zzwong
zzwong marked this pull request as ready for review September 29, 2026 23:29
@zzwong
zzwong merged commit 2e18b52 into main Sep 30, 2026
10 checks passed
@zzwong
zzwong deleted the zzwong/claude-cli-max-effort branch September 30, 2026 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants