docs: explain reviewer tool evidence in task artifacts - #584
Merged
Conversation
monit-reviewer
approved these changes
Sep 7, 2026
monit-reviewer
left a comment
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: 28640c468d13
Profile: open-cli-collective-review - Posting as: monit-reviewer
Summary
| Reviewer | Findings |
|---|---|
| documentation:docs | 0 |
| policies:conventions | 0 |
Reviewer Coverage
documentation:docs— complete (broad); skipped: none; constraints: Review scope was limited to the assigned documentation change and its directly referenced lifecycle, adapter, pipeline, and coverage sources.policies:conventions— complete (broad); skipped: none; constraints: Reviewed only the assigned documentation change; shared CLI standards were not present in the provided repository context.
Inspected files (1)
docs/llm-task-artifacts.md
0 PR discussion threads considered. 0 summarized; 0 resolved.
Completed in 1m 35s | $0.03 | openai-codex/gpt-5.6-terra | cr 0.10.299
| Field | Value |
|---|---|
| Model | openai-codex/gpt-5.6-terra |
| Reviewers | documentation:docs, policies:conventions |
| Engine | pi_rpc · openai-codex/gpt-5.6-terra |
| Reviewed by | cr · monit-reviewer |
| Duration | 1m 35s wall · 2m 07s compute |
| Cost | $0.03 |
| Tokens | 6.0k in / 632 out |
Per-workstream usage
orchestrator-selection— openai-codex/gpt-5.6-terra- In: 818
- Out: 143
- Cache read: 4.9k
- Cache create: 0
- Cost: $0.00
- Duration: 17s
documentation:docs— openai-codex/gpt-5.6-terra- In: 1.9k
- Out: 299
- Cache read: 17.9k
- Cache create: 0
- Cost: $0.01
- Duration: 1m 05s
policies:conventions— openai-codex/gpt-5.6-terra- In: 2.2k
- Out: 153
- Cache read: 3.6k
- Cache create: 0
- Cost: $0.01
- Duration: 41s
orchestrator-rollup— openai-codex/gpt-5.6-terra- In: 1.1k
- Out: 37
- Cache read: 2.8k
- Cache create: 0
- Cost: $0.00
- Duration: 2s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #551.
A reviewer task can finish successfully while its review still cannot approve: task success means the returned structured output is valid, while review coverage also depends on the required diff-tool evidence. The artifact guide explained task statuses and telemetry but omitted
reviewer_tool_evidence, leaving that combination unexplained for anyone inspecting a saved or resumed run.This adds the missing field to the guide's behaviorally significant metadata and documents its existing contract in one place.
What the guide now explains
diff_statusvalues:not_invoked,incomplete,succeeded, andfailed, plus the optionaldiff_diagnosticstring.incomplete_toolcoverage and turns an otherwise approving review into a comment.The example makes the distinction concrete:
{ "status": "succeeded", "reviewer_tool_evidence": { "diff_status": "failed", "diff_diagnostic": "fixed diff unavailable" } }This task has valid output, but its failed tool evidence prevents complete review coverage. The guide also distinguishes an absent field from explicit
not_invokedevidence and explains that successful tool evidence still requires the normal assigned-file coverage checks.Scope and verification
The change is confined to
docs/llm-task-artifacts.mdand describes the implemented behavior. The companion reporting correction is in #585.