Repository navigation
Update flow-go to v0.51.0 in Go test suite - #619
Merged
Merged
Conversation
- Bump github.com/onflow/flow-go from the v0.47.0-ledger-service pseudo-version to v0.51.0 (Cadence v1.10.6, atree v0.16.1, flow-go-sdk v1.10.8) - Remove the stale go-ethereum v1.16.8 replace directive; flow-go v0.51.0 resolves go-ethereum v1.17.4 natively - Raise the gas limit in TestIDTableUnstakeAllManyDelegators from 2M to 10M: new metering prices the 2000-delegator registration tx at ~3.2M computation, just over the old 2M limit - Bump CI Go version to 1.26 to match the new go directive required by flow-go v0.51.0
Flow CLI v2.18.0 (used by CI) embeds flow-go v0.51.x, which charges EIP-8037 state-creation gas (120 bytes * 1530 = 183600) when a call funds a fresh EOA. The scheduled EVM call to a fresh address with a 100000 gas limit now runs out of gas (needs ~204600). Raise the limit to 300000.
SupunS
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the flow-go dependency used by the Go integration test suite from the v0.47.0-ledger-service pseudo-version (March 2026) to the v0.51.0 release.
Changes
github.com/onflow/flow-goto v0.51.0 inlib/go/test(brings Cadence v1.10.6, atree v0.16.1, flow-go-sdk v1.10.8)go-ethereum => v1.16.8replace directive, which silently downgraded geth and no longer compiles against flow-go v0.51.0; geth now resolves to v1.17.4TestIDTableUnstakeAllManyDelegatorsfrom 2M to 10M: the new metering prices the 2000-delegator registration transaction at ~3.2M computation, just over the old 2M limit. The test already configures the emulator max at 100MtestCOAScheduledTransactionsfrom 100k to 300k: Flow CLI v2.18.0 (installed by CI from master) embeds flow-go v0.51.x, which charges EIP-8037 state-creation gas (120 bytes x 1530 = 183600) when a call funds a fresh EOA, so the scheduled call to a fresh address needs ~205k gas. This failure is pre-existing on master with CLI v2.18.0 and unrelated to the Go dependency bump; it was reproduced locally with CLI v2.18.0 and the fix verified against itgo 1.26.0directive required by flow-go v0.51.0make generate,make test, andmake ciall pass, with the Cadence suite run against Flow CLI v2.18.0.