Repository navigation
Update occurrence creation through locality -> occurrences tab, and improve tables - #1241
Merged
juhanikat merged 57 commits intoOct 15, 2026
Merged
Conversation
…e occurrence creation
…locality route in backend, also add button to select species for occurrence
…occurrence creation
… in occurrence route just in case
…modal save button not disabling properly
…om locality to occurrence/species details
karilint
self-requested a review
October 6, 2026 08:54
karilint
reviewed
Oct 6, 2026
karilint
left a comment
Collaborator
There was a problem hiding this comment.
When a new Occurrence is created and a new Species is made using an existing species as a template, the value of Succlass or Suborder is not copied to the new species.
…e occurrence redux typing
… and fix those fields not saving when creating/editing Occurrences
… not saving properly
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Species-changing saves can lose occurrence edits, and locality-created occurrences lack server-side field validation.
9 open findings
Validate new occurrence fields before locality writes · New Preserve edited occurrence fields when changing species · New Fix OccurrenceCoreTab species query test setup · New Use text assertions scoped to the selector modal · New Remove it.only from navigation tests · New Avoid full locality graph fetches on occurrence reads · New Skip species queries on read-only occurrence pages · New Update wear-tab mocks and stale field expectations · New Restore selector guards for Contact and New buttons · New
7 resolved since last review
Occurrence detail type mismatches backend query fields Route matches arbitrary occurrence path segments New button incorrectly depends on showContactButton Null taxonomy fields copied with non-null assertions Mutating shared emptyOccurrence reference Locality updates issue queries for every occurrence Unique Identifier does not use missing-value formatting
🧠 Review effort: Lite
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
juhanikat
marked this pull request as ready for review
October 15, 2026 09:37
juhanikat
deleted the
update-occurrence-creation-and-locality-occurrence-tab
branch
October 15, 2026 09:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



New occurrences can now be created directly from the Locality -> Occurrences tab. Creating new Occurrences directly from the Occurrences table is still disabled.
When creating a new Occurrence, the locality is set automatically, and the species can only be selected from a table of existing species. Species that are already listed as Occurrences for that locality are not able to be selected.
This PR also changes some functionality for the tableviews, for example, clicking rows in some editing tables no longer navigates the user to the details of those rows.