fix: ignore node/ directory in ESLint config - #1024
Open
btea wants to merge 2 commits into
Open
Conversation
The `node/` directory contains a checkout of the Node.js source tree whose own `eslint.config.mjs` references files that don't exist in this repo (e.g. `benchmark/eslint.config_partial.mjs`). Add it to the `ignores` list so `node --run lint` doesn't fail.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1024 +/- ##
=======================================
Coverage 89.43% 89.43%
=======================================
Files 203 203
Lines 18871 18871
Branches 1763 1763
=======================================
Hits 16878 16878
Misses 1986 1986
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AugustinMauroy
approved these changes
Aug 11, 2026
AugustinMauroy
left a comment
AugustinMauroy
left a comment
Member
There was a problem hiding this comment.
LGMT ! I was thinking ESlint always ignore file listed on gitinonre
avivkeller
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
node/directory contains a checkout of the Node.js source tree whose owneslint.config.mjsreferences files that don't exist in this repo (e.g.benchmark/eslint.config_partial.mjs). Add it to theignoreslist sonode --run lintdoesn't fail.Validation
Related Issues
Check List
node --run testand all tests passed.node --run format:check&node --run lint.