Repository navigation
feat(call): Show when push to talk is active - #2790
Draft
karlitschek wants to merge 1 commit into
Draft
karlitschek wants to merge 1 commit into
karlitschek wants to merge 1 commit into
Conversation
Holding the mute button or the space bar already unmutes the microphone while held. As the finger covers the mute button, it was hard to tell that the microphone is really on. A green "You are talking" pill is now shown above the call buttons while push to talk is active, VoiceOver announces it, and releasing gives a light haptic. Also fixes releasing the space bar calling super.pressesBegan instead of super.pressesEnded, and ends push to talk when the key press is cancelled, e.g. when the app goes to the background. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Frank Karlitschek <karlitschek@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Holding the mute button or the space bar already unmutes the microphone while held (push to talk). As the finger covers the mute button, it was hard to tell that the microphone is really on.
super.pressesBeganinstead ofsuper.pressesEndedNotes
mainonce feat: Widgets, Spotlight, haptics, double tap reactions and thermal aware calls聽#2788 is merged.Testing
generic/platform=iOS(iPhone, iPad, Mac "Designed for iPad") and for watchOS hardware馃 Generated with Claude Code