Skip to content

Fields with numeric consts default value are incorrectly marked as required #216

Description

@nickvergessen

Controller

	public function createRoomV2(
		string $name,
		int $type = Room::TYPE_GROUP,
		int $readOnly = Room::READ_WRITE,
		int $listable = Room::LISTABLE_NONE,
		int $messageExpiration = 0,
		int $lobbyState = Webinary::LOBBY_NONE,
		?int $lobbyTimer = null,
		int $sipEnabled = Webinary::SIP_DISABLED,
		int $permissions = Attendee::PERMISSIONS_DEFAULT,
		int $recordingConsent = RecordingService::CONSENT_REQUIRED_NO,
		int $mentionPermissions = Room::MENTION_PERMISSIONS_EVERYONE,
		string $description = '',
		?string $password = null,
		?string $objectType = null,
		?string $objectId = null,
		?string $emoji = null,
		?string $avatarColor = null,
		array $participants = [],
	): DataResponse {

Expectation

Only name is marked as required

Actual

Also fields with consts as default are marked as required

Image

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions