Feature: Publish Collective as Static Website - #2769
Draft
code4candy wants to merge 3 commits into
Draft
code4candy wants to merge 3 commits into
code4candy wants to merge 3 commits into
Conversation
mejo-
requested changes
Sep 15, 2026
mejo-
left a comment
mejo-
left a comment
Member
There was a problem hiding this comment.
Overall looks great 😊 I have some comments on the backend part, the frontend looks fine from reading the code.
|
|
||
| test.describe('Collective publish', () => { | ||
| test('admin can open publish modal', async ({ collective, navigation, page }) => { | ||
| await runOcc(['config:app:set', 'collectives', 'publish_enabled', '--value', 'true']) |
Member
There was a problem hiding this comment.
Maybe it helps to move the runOcc command to beforeEach()? You seem to do it at the start of all tests anyway.
kjoscha
force-pushed
the
feature/collectives-publish
branch
2 times, most recently
from
September 22, 2026 08:55
7cebf56 to
63fc23e
Compare
Since the settings area is not in the Collectives scope, we should prefix the header with collective or BETTER move both settings under a "Collectives" heading |
kjoscha
force-pushed
the
feature/collectives-publish
branch
from
September 22, 2026 12:34
8825b60 to
13eabe3
Compare
Signed-off-by: kayoshi <jo5cha@web.de> Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: kayoshi <jo5cha@web.de> Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
Signed-off-by: kayoshi <jo5cha@web.de> Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-sonnet-5
kjoscha
force-pushed
the
feature/collectives-publish
branch
from
September 22, 2026 12:40
13eabe3 to
20f507c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
This is the first step towards the publishing feature, that we implement as part of the funding program Prototype Fund (get more information here: https://github.com/nextcloud-publish). This is not going to be merged after a first review, but works as intermediate working tree for the feature.
Description
To initiate the publication of a website, each Collective should have a Publish button that opens a modal window where the publishing process can subsequently be configured.
The page selection and configuration process itself is out of scope for this issue.
Acceptance Criteria
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)