Bookmark icons appear as question marks on Dashboard

[theking2]

All bookmarks appear as question mark icons on the dashboard. Shouldn't these be the favicons of the websites, as they appear in Firefox?

Nextcloud version 33.0.2, Plugin version 16.1.4

[github-actions]

Hello 👋

Thank you for taking the time to open this issue with the bookmarks app. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and have been maintaining this software the last few years. I currently work for Nextcloud but maintain this app
in my free time, because it is not an official Nextcloud product. My day job at Nextcloud is pretty awesome but sadly leaves me with
less time for side projects like this one than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself. (Also see our Code of Conduct. Really.)

I look forward to working with you on this issue
Cheers 💙

[marcelklehr]

Hi @theking2
Thank you for taking the time to give feedback!

All bookmarks appear as question mark icons on the dashboard. Shouldn't these be the favicons of the websites, as they appear in Firefox?

Do these webpages have favicons in the normal bookmarks app UI for you? It could be that you haven't enabled internet access for the app (which is opt-in due for privacy reasons). If you have enabled internet access, it still might take a while until all bookmarks have been crawled depending on how many you have.

[theking2]

All have favicons. is there a occ command to refresh them?

[marcelklehr]

All have favicons.

Mmh, then refreshing won't help.

[theking2]

In the browser dev tools I see then retrieved from https://office.kingma.ch/apps/bookmarks/bookmark/{id}/favicon. which fails 404

[theking2]

If someone can hint me where this is in the code I might pr this.

[marcelklehr]

Awesome! I would fix it if I knew what the problem was, but the normal UI uses the same route, so if, as you say, the favicons display there, it's a Schrödinger's favicon. Anyway, here's the controller endpoint for the route you mentioned: https://github.com/nextcloud/bookmarks/blob/master/lib/Controller/BookmarkController.php#L552