Repository navigation
fix: removing unit test cases upload step to code cov - #553
Merged
aavinash-nr merged 2 commits intoOct 12, 2026
Merged
aavinash-nr merged 2 commits into
aavinash-nr merged 2 commits into
Conversation
CodeQL flagged actions/missing-workflow-permissions across 12 workflows
that had no explicit permissions block, leaving the default GITHUB_TOKEN
scope implicit. Add least-privilege permissions to each:
- nodejs.yml, python.yml, ruby.yml: contents: read (checkout/lint/test only)
- validate-layer.yml, publish-java-agent.yml: contents: read (checkout +
build/publish scripts, no GitHub API calls)
- publish-java.yml, publish-node.yml, publish-python.yml, publish-ruby.yml,
publish-dotnet.yml, publish-extension.yml: contents: read, actions: read
(notify-slack job uses `gh api .../actions/runs/{id}/jobs` and
`gh run download` to build the Slack release summary)
- repolinter.yml: contents: read, issues: write (repolinter-action opens
a GitHub issue on findings)
dependency-submission.yml already declared explicit permissions and was
left unchanged.
NR-560188
The "Upload Unit Test Coverage" step (codecov/codecov-action) ran after
the real layer/ECR publish steps in both publish-node and
publish-node-universal, with fail_ci_if_error: true. A Codecov-side
signature verification failure ("Could not verify signature") has been
failing this step on every recent run, which marks the whole job as
failed even though the layer had already published successfully.
Coverage reporting token changes can't fix this — the failure happens
during the Codecov CLI's own binary signature check, before the token
is ever used.
Removing the step entirely rather than patching it: a coverage-upload
step should never be able to block a release, and coverage visibility
is unaffected since nodejs.yml already archives the same lcov.info as
a build artifact on every push/PR.
aavinash-nr
added a commit
to aavinash-nr/newrelic-lambda-layers
that referenced
this pull request
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.