Skip to content

fix(chart): default the internal gateway and issuer to what NIC creates - #254

Merged
dcmcand merged 1 commit into
mainfrom
fix/233-nic-defaults
Nov 20, 2026
Merged

dcmcand merged 1 commit into
mainfrom
fix/233-nic-defaults

Conversation

@dcmcand

@dcmcand dcmcand commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Part of #233.

What changed

  • platform.gateway.internal.name defaults to nebari-gateway (was nebari-internal-gateway).
  • platform.tls.clusterIssuer defaults to letsencrypt-issuer (was letsencrypt-production). The operator's LLM_CLUSTER_ISSUER_NAME fallback changes to match, and config_test.go's three default-value cases expect the new name.
  • README, configuration, quickstart, installation and troubleshooting docs state the new defaults. The runbook's "NIC ships X, not the chart default" comments are gone.
  • upgrading.mdx has a new entry for clusters that relied on either old default.

Why

NIC creates one Gateway, nebari-gateway, and the ClusterIssuer letsencrypt-issuer. The chart defaulted to names NIC doesn't create. On a fresh NIC cluster the internal HTTPRoute attached to a Gateway that doesn't exist, no listener served llm-internal.<baseDomain>, and clients got the catch-all certificate and failed the TLS name check. The shared Certificate also pointed at an issuer that wasn't there.

The issuer won't always be letsencrypt-issuer; NIC will grow other issuer options. The default matches what NIC ships today. The longer-term fix is for the chart to read the issuer from NIC's platform values (P5 in nebari-dev/nebari-infrastructure-core#781), with platform.tls.clusterIssuer as the override. That's a follow-up once P5 exists.

dev/gateways.yaml keeps its two Gateways. The dev operator sets its gateway env vars directly, so it doesn't use these defaults, and it's the only place the split-gateway setup gets exercised.

The other half of #233, making InternalEndpointReady/ExternalEndpointReady follow the HTTPRoute's Accepted condition, comes in a separate PR stacked on #173.

How to test

  • cd operator && make test (with AI_GATEWAY_CRD_DIR set as in CI): all packages pass.
  • helm lint charts/nebari-llm-serving/: clean.
  • helm template with default values renders LLM_INTERNAL_GATEWAY_NAME=nebari-gateway and LLM_CLUSTER_ISSUER_NAME=letsencrypt-issuer.
  • cd docs && npm test: 31/31.
  • Not run locally, left to CI: make lint (local golangci-lint v2.4.0 can't read the local Go toolchain's export data) and the docs build (local Node is below Astro's minimum).

platform.gateway.internal.name defaulted to nebari-internal-gateway and
platform.tls.clusterIssuer to letsencrypt-production. NIC creates neither:
it ships one Gateway, nebari-gateway, and the ClusterIssuer
letsencrypt-issuer. On a default NIC install the internal HTTPRoute
attached to a Gateway that doesn't exist, no listener served
llm-internal.<baseDomain>, and the shared Certificate pointed at a
missing issuer.

Default both values to NIC's names, and change the operator's
LLM_CLUSTER_ISSUER_NAME fallback to match the chart. The issuer default
stays a value until NIC publishes its issuer to packs (#781 in
nebari-infrastructure-core).

Update the docs that state the old defaults, and add an upgrade note for
clusters that relied on them.

Part of #233.
@github-actions

Copy link
Copy Markdown

📄 Docs preview for fix/233-nic-defaults:
https://fix-233-nic-defaults.llm-serving-pack.pages.dev

@dcmcand
dcmcand requested review from aktech and jbouder November 20, 2026 10:48

@jbouder jbouder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defaults now match what NIC creates. Both endpoints sharing one Gateway is safe: listeners are per-hostname and auth stays per-route via sectionName. The upgrade note covers clusters that relied on the old names.

@dcmcand
dcmcand merged commit 0b3adb7 into main Nov 20, 2026
22 checks passed
@dcmcand
dcmcand deleted the fix/233-nic-defaults branch November 20, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants