Repository navigation
fix(chart): default the internal gateway and issuer to what NIC creates - #254
Merged
Merged
Conversation
platform.gateway.internal.name defaulted to nebari-internal-gateway and platform.tls.clusterIssuer to letsencrypt-production. NIC creates neither: it ships one Gateway, nebari-gateway, and the ClusterIssuer letsencrypt-issuer. On a default NIC install the internal HTTPRoute attached to a Gateway that doesn't exist, no listener served llm-internal.<baseDomain>, and the shared Certificate pointed at a missing issuer. Default both values to NIC's names, and change the operator's LLM_CLUSTER_ISSUER_NAME fallback to match the chart. The issuer default stays a value until NIC publishes its issuer to packs (#781 in nebari-infrastructure-core). Update the docs that state the old defaults, and add an upgrade note for clusters that relied on them. Part of #233.
|
📄 Docs preview for |
jbouder
approved these changes
Nov 20, 2026
jbouder
left a comment
Contributor
There was a problem hiding this comment.
Defaults now match what NIC creates. Both endpoints sharing one Gateway is safe: listeners are per-hostname and auth stays per-route via sectionName. The upgrade note covers clusters that relied on the old names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #233.
What changed
platform.gateway.internal.namedefaults tonebari-gateway(wasnebari-internal-gateway).platform.tls.clusterIssuerdefaults toletsencrypt-issuer(wasletsencrypt-production). The operator'sLLM_CLUSTER_ISSUER_NAMEfallback changes to match, andconfig_test.go's three default-value cases expect the new name.upgrading.mdxhas a new entry for clusters that relied on either old default.Why
NIC creates one Gateway,
nebari-gateway, and the ClusterIssuerletsencrypt-issuer. The chart defaulted to names NIC doesn't create. On a fresh NIC cluster the internal HTTPRoute attached to a Gateway that doesn't exist, no listener servedllm-internal.<baseDomain>, and clients got the catch-all certificate and failed the TLS name check. The shared Certificate also pointed at an issuer that wasn't there.The issuer won't always be
letsencrypt-issuer; NIC will grow other issuer options. The default matches what NIC ships today. The longer-term fix is for the chart to read the issuer from NIC's platform values (P5 in nebari-dev/nebari-infrastructure-core#781), withplatform.tls.clusterIssueras the override. That's a follow-up once P5 exists.dev/gateways.yamlkeeps its two Gateways. The dev operator sets its gateway env vars directly, so it doesn't use these defaults, and it's the only place the split-gateway setup gets exercised.The other half of #233, making
InternalEndpointReady/ExternalEndpointReadyfollow the HTTPRoute'sAcceptedcondition, comes in a separate PR stacked on #173.How to test
cd operator && make test(withAI_GATEWAY_CRD_DIRset as in CI): all packages pass.helm lint charts/nebari-llm-serving/: clean.helm templatewith default values rendersLLM_INTERNAL_GATEWAY_NAME=nebari-gatewayandLLM_CLUSTER_ISSUER_NAME=letsencrypt-issuer.cd docs && npm test: 31/31.make lint(local golangci-lint v2.4.0 can't read the local Go toolchain's export data) and the docs build (local Node is below Astro's minimum).