Repository navigation
feat(alert-cur-events): add fullscreen live view - #2301
Conversation
Add a fullscreen wall mode for the active alert events list, toggled by a fullscreen button. In this mode the table fetches page 1 on a refresh cadence, disables selection/pagination/row actions, and highlights rows whose hash did not appear in the previous fetch.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟡 Changes recommended
There are two user-visible state bugs: fullscreen UI state can desync without an initial sync, and exiting fullscreen currently forces the shared auto-refresh cache to Off (unexpectedly disabling polling in the normal list).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a fullscreen “wall mode” for the current alert events list, allowing operators to monitor live events with simplified controls and visual highlighting for newly appearing events.
Changes:
- Added fullscreen entry/exit flow in the current events list page and a dedicated fullscreen header wrapper (
FullscreenList). - Updated
AlertTableto support fullscreen behavior (force page 1, disable selection/pagination/row actions, highlight newly seen event hashes). - Fixed
AutoRefreshto correctly treat an explicit0intervalSeconds value (via??instead of||).
File summaries
| File | Description |
|---|---|
| src/pages/alertCurEvent/pages/List/index.tsx | Adds fullscreen toggle + conditional rendering between normal and fullscreen layouts. |
| src/pages/alertCurEvent/pages/List/FullscreenList.tsx | New fullscreen header/container with live indicator and refresh/range controls. |
| src/pages/alertCurEvent/pages/List/AlertTable.tsx | Implements fullscreen-specific fetch/presentation rules and “new row” highlighting. |
| src/components/TimeRangePicker/AutoRefresh/index.tsx | Correctly handles intervalSeconds={0} without falling back to cache. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| useEffect(() => { | ||
| return () => { | ||
| localStorage.setItem(`${TIME_RANGE_CACHE_KEY}_refresh`, '0'); | ||
| }; | ||
| }, []); |
| useEffect(() => { | ||
| const syncFullscreenState = () => setIsFullscreen(document.fullscreenElement === fullscreenRef.current); | ||
| document.addEventListener('fullscreenchange', syncFullscreenState); | ||
| return () => document.removeEventListener('fullscreenchange', syncFullscreenState); | ||
| }, []); |
|
每日 i18n Review（2026-09-09）发现本 PR 新增的 |
Add a fullscreen wall mode for the active alert events list, toggled by a fullscreen button. In this mode the table fetches page 1 on a refresh cadence, disables selection/pagination/row actions, and highlights rows whose hash did not appear in the previous fetch.