Revert "mapfixes: add model transparency fixes" - #748
Merged
Conversation
This reverts commit 6f7c139.
There was a problem hiding this comment.
🟢 Approval recommended
The revert restores MTA 1.6 compatibility with no unresolved review issues.
Pull request overview
Reverts the model transparency fixes to preserve compatibility with MTA 1.6 servers and clients.
Changes:
- Removes transparency-fix data and client logic.
- Removes the related resource setting.
- Restores the minimum MTA version to 1.6.
File summaries
| File | Description |
|---|---|
[gameplay]/mapfixes/scripts/shared/data.lua |
Removes transparency-fix data. |
[gameplay]/mapfixes/scripts/client/main.lua |
Removes model flag handling. |
[gameplay]/mapfixes/meta.xml |
Restores 1.6 compatibility and removes the setting. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has to wait until 1.7 is released otherwise when a 1.6 server pulls in the latest resources, they'll be forced to only accept 1.7 clients. cc @Fernando-A-Rocha @ArranTuna
Original PR #590