Repository navigation
Make gameboard use edn instead of json, take 2 - #8856
Open
NoahTheDuke wants to merge 1 commit into
Open
NoahTheDuke wants to merge 1 commit into
NoahTheDuke wants to merge 1 commit into
Conversation
NoahTheDuke
force-pushed
the
nb/edn-cljs
branch
from
September 4, 2026 13:38
455eac8 to
67a962b
Compare
NoahTheDuke
force-pushed
the
nb/edn-cljs
branch
from
September 21, 2026 17:40
67a962b to
c3094ef
Compare
csbisa
reviewed
Sep 30, 2026
csbisa
left a comment
csbisa
left a comment
Contributor
There was a problem hiding this comment.
This doesn't seem to solve our i18n breakage problem by itself, so more investigation is needed.
NoahTheDuke
force-pushed
the
nb/edn-cljs
branch
from
September 30, 2026 16:28
c3094ef to
3b0a3a2
Compare
NoahTheDuke
force-pushed
the
nb/edn-cljs
branch
from
September 30, 2026 17:35
3b0a3a2 to
24acaaf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i did this back in #7564 but i chickened out of merging it and then it bit-rotted. i think it's worthwhile to do tho, so i redid the entire thing by hand and i'm submitting it again. it simplifies and unifies a bunch of our code, and i think it's nicer overall.