Skip to content

Addition of movementX/Y to MouseEvent #29

Open

Description

@pro100filipp

According to official docs, movementX/Y is well-supported both by Safari and iOS. If you don't mind, I'd like to make a PR adding it.

Activity

  1. mpizenberg commented on Jun 19, 2023

    @mpizenberg
    Owner

    Hum, according to the docs, it’s well supported for quite some time (2015), roughly the same as FF and chrome. And I started this library around 2017. So I suspect there was still something not working well with movementX/Y ... (but I don’t remember what, maybe related to "pointer" events?)
    Would you mind being extra precautious with testing it’s behaving the same in different OS?
    Then the PR is welcome of course!

  2. pro100filipp commented on Jun 19, 2023

    @pro100filipp
    Author

    Yes, that also seemed strange to me. I'll do some investigation and tell about results. Hope in 2023 it'll "just work" though :)

  3. pro100filipp commented on Jun 19, 2023

    @pro100filipp
    Author

    Unfortunately, mobile Safari PointerEvent really does not have movementX/Y. I also did some testing on Chrome, Brave and FF – none of them had movementX/Y too. MDN standard looks like a fucking joke – even in 2023.

    The issue can be closed I think, sorry for the disturbance(

  4. mpizenberg commented on Jun 19, 2023

    @mpizenberg
    Owner

    Thanks for checking

  5. mpizenberg commented on Jun 19, 2023

    @mpizenberg
    Owner

    Also, as I often say to other people with specific requests, this package is convenient for quick prototyping, but don’t hesitate to extract the functions and decoder you need instead of depending on the package.

  6. pro100filipp commented on Jun 19, 2023

    @pro100filipp
    Author

    Of course – and thank you for the convenient API made for this) Just thought it'd be a good candidate for a standard functionality

  7. mpizenberg commented on Jun 19, 2023

    @mpizenberg
    Owner

    Note to self (or anyone willing to do a docs PR): better explain that movementX/Y are not in because the support for pointer events is not good, and we are reusing the same decoder for mouse events and pointer events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions