Add gson and bump Hilt to 2.60.1 for AGP 9 - #5
Merged
Merged
Conversation
The AAR references com.google.gson internally and declares no transitive dependencies, so the app has to supply it explicitly.
Hilt's Gradle plugin uses AGP's legacy BaseExtension, which AGP 9 removed, so 2.57.2 fails at apply with 'Android BaseExtension not found'. AGP 9 support landed in 2.59 (dagger#4944) with follow-up fixes in 2.59.1 and 2.59.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both found by migrating health.
Hilt 2.57.2 does not work on AGP 9. Its Gradle plugin uses AGP's legacy
BaseExtension, which AGP 9 removed:AGP 9 support landed in Hilt 2.59 (dagger#4944), with follow-up fixes in 2.59.1 (jetifier) and 2.59.2 (slow incremental builds). Bumped to the current 2.60.1.
This would have hit footprint identically, so it is now paid for once.
gson is health's vendored Samsung Health Data SDK AAR's unresolved runtime dependency: the AAR references
com.google.gsoninternally and declares no transitive deps, so the app supplies it explicitly.Verified by building health locally: Hilt, KSP, Moshi, Room, WorkManager, the vendored AAR and a
minSdk 29override all compile, andktlintCheck lintDebug testDebugUnitTestpass.