Skip to content

Log runtime store namespaces instead of keys - #2577

Open
jeremi wants to merge 1 commit into
mosip:develop-gofrom
jeremi:fix/go-runtime-store-diagnostics
Open

jeremi wants to merge 1 commit into
mosip:develop-gofrom
jeremi:fix/go-runtime-store-diagnostics

Conversation

@jeremi

@jeremi jeremi commented Sep 9, 2026

Copy link
Copy Markdown

Runtime-store debug events now identify the store namespace instead of emitting each entry's key. Apply the same behavior to Put, PutIfNotExists, and Take in the Redis and in-memory providers; storage behavior is unchanged.

Add regressions to both existing service test suites that initialize debug logging in an isolated process, exercise all three operations, and require namespace diagnostics while excluding synthetic keys and values.

Validation:

  • The new regressions fail against unchanged upstream code and pass with this change.
  • GOTOOLCHAIN=go1.26.0 ./make.sh test passes all 25 test packages with race detection and coverage.
  • Focused lint for ./internal/engine/runtimestores/... passes with zero issues.
  • Full ./make.sh lint reports the same three existing SA1019 findings as unchanged upstream runtime source, in PKCS#11 key handling and security JWKS parsing. No findings are in changed files.
  • git diff --check passes.

Signed-off-by: Jeremi Joslin <jeremi@joslin.fr>
@coderabbitai

coderabbitai Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 54 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: a8942241-c02e-46c4-b0a9-aafa63ba419f

📥 Commits

Reviewing files that changed from the base of the PR and between 4d3e36e and a3a3f93.

📒 Files selected for processing (4)
  • esignet-service/internal/engine/runtimestores/inmemory/privacy_test.go
  • esignet-service/internal/engine/runtimestores/inmemory/service.go
  • esignet-service/internal/engine/runtimestores/redisstore/privacy_test.go
  • esignet-service/internal/engine/runtimestores/redisstore/service.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

codecov-commenter commented Sep 24, 2026 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop-go@be4687a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../internal/engine/runtimestores/inmemory/service.go 66.66% 1 Missing ⚠️
...nternal/engine/runtimestores/redisstore/service.go 66.66% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@              Coverage Diff              @@
##             develop-go    #2577   +/-   ##
=============================================
  Coverage              ?   70.18%           
=============================================
  Files                 ?      129           
  Lines                 ?     8950           
  Branches              ?      111           
=============================================
  Hits                  ?     6282           
  Misses                ?     2207           
  Partials              ?      461           
Flag Coverage Δ
go 69.06% <66.66%> (?)
npm 92.20% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zesu22

zesu22 commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants