Repository navigation
Keep sort spill checks within their overall deadline - #72
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unchanged Windows spill scenario passed in PR #71 at 14.27 seconds, then exceeded its 15-second child wait on the first main run. Allow 30 seconds for child completion within the existing 60-second overall case deadline.
Preserve the full input, live spill observation, exact sorted output, selected/fallback directory checks, and child cleanup. No product code, package version, corpus value, or performance acceptance threshold changes.
Validation: local full Wasm functional suite passes 2,520 checks with 21 platform exclusions and zero failures; all finite obligations remain satisfied; interface, formatting, and generated-index checks pass. The initial failed main log and artifacts are retained.