Repository navigation
Refactor tests around one entry and explicit data ownership - #69
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 732085a6c7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "candidate": true, | ||
| "core_version": module_field("core/moon.mod", "version"), | ||
| "base_manifest": "active-cases.json", | ||
| "base_manifest": "../cases/manifest.json", |
There was a problem hiding this comment.
Allow the candidate's cross-directory case reference
When the release-acceptance workflow selects candidate, this generated base_manifest is rejected before any acceptance cases run: published_coordinates() in tests/harness/driver/published.mbt passes it to safe_relative_path(), which explicitly rejects every .. component. Consequently, both the committed candidate and every candidate regenerated by index update fail with unsafe published case path, although the default latest manifest still works. Update the manifest-path validation to support the new cross-directory reference while retaining an appropriate containment check.
Useful? React with 👍 / 👎.
Test automation mixed CLI cases, release selections, coverage reviews, generated evidence and command-specific assertions across overlapping directories. This change establishes
tests/run.mbtxas the local/CI entry, gives current data explicit owners, and removes the old execution paths without forwarding wrappers.index check/update; CI rejects stale generated quality, coverage, gap and candidate files. Committed gap indexes describe definitions only; actual execution receipts remain under fresh report roots. Scope LF checkout rules to these JSON definitions so byte comparisons remain deterministic on Windows.latest.json/latest-cases.jsonbyte-for-byte. Product source, APIs and package versions are unchanged.Validation on macOS: 1,800 Wasm package tests; 201 Native tool tests; 2,274 functional passes and 21 explicit platform skips; all 652 reviewed coverage obligations qualified, with 213 unresolved obligations still reported. Unified product/tool/script checks, generated-index check, explicit formatting, architecture validation (80 commands/127 packages), nested-directory selection, published-manifest validation and local documentation links pass.
Required Linux, macOS and Windows development checks pass at
732085a6c714529628240691f58f89f1792c18d7, including pinned Linux upstream comparisons. The first Windows attempt hit four existing 10-second PowerShell observer timeouts in mv link tests; one Windows-only rerun passed all 1,800 package tests, 201 tool tests and functional checks with the same assertions and timeout settings. The original failure remains recorded.Manual resource/performance and uploaded-coordinate acceptance workflows were not run. Actual-main validation remains after merge.