Repository navigation
DRIVERS-3206 Address flakiness in command logging, retryable reads, and retryable writes unified tests for retryable handshake errors - #1988
Conversation
…tests for retryable handshake errors
| - commandStartedEvent | ||
| - commandSucceededEvent | ||
| - commandFailedEvent | ||
| uriOptions: |
There was a problem hiding this comment.
In the beginning of this file it says Tests in this file are generated from handshakeError.yml.template.
Is it still true? If so, should we modify the template file as well?
| id: &failPointClient failPointClient | ||
| useMultipleMongoses: false | ||
| uriOptions: | ||
| appName: "commandLoggingRedactionTest" |
There was a problem hiding this comment.
Shouldn't this be setup on the main client? I think setting it up here will be valid only for the failpoint client.
| data: | ||
| failCommands: [ping, saslContinue] | ||
| closeConnection: true | ||
| appName: "retryableReadHandshakeTest" |
There was a problem hiding this comment.
I think that the yml and json files are correct, but I think you need to fix the source .template file to add the appName. Otherwise when regenerating the yml files those should be lost.
There was a problem hiding this comment.
source/retryable-reads/tests/etc/templates/handshakeError.yml.template does have this change in the latest commit.
There was a problem hiding this comment.
The template has the appName now, but only for the client. The template is missing the appName for the failpoint setup. From what I can see you should add it to line 75 and 127 in the reads template and 71 and 120 in writes template. Am I missing something?
There was a problem hiding this comment.
Sorry, I misunderstood your comment, fixed!
|
Assigned |
3 participants
Add
appNameto each failpoint that deals with authenticated handshake failures in the three named test suites to prevent another background or racing operation from stealing the failpoint trigger.Please complete the following before merging:
clusters).