CSHARP-6214: Implement srvAllowedHostsSuffix URI option - #2126
Merged
Merged
Conversation
(cherry picked from commit f981df0)
…tings method The public ClusterSettings constructor and With overload keep their released signatures; adding an optional parameter to either is a binary break, and an overload carrying the extra parameter makes every call that omits it ambiguous. WithSrvAllowedHostsSuffix sets the value instead, and With carries it across.
adelinowona
requested review from
sanych-sun
and removed request for
papafe
September 17, 2026 00:23
The check compensates for the NLS globalization backend, which returns all-ASCII input from GetAscii without decoding it. .NET Core 3.1 on Windows runs the netstandard2.1 build on NLS, so that target needs the check as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #2109 to
v3.x.patch here