[mandritschke]

Fixes #1268

• instead of just updating existing properties allows to insert completely new properties new properties overriding properties from parent POM
• works for properties on the project level as well as on the profile level (that is if a profile id is given)
• though this implementation won't create new profiles at the moment, this could be a possible enhancement, let me know if this sounds useful
• formatting was kind of a challenge

Usage

mvn org.codehaus.mojo:versions-maven-plugin:2.21.1-SNAPSHOT:set-property \
  -Dproperty=mockitoVersion \
  -DnewVersion=4.11.1 \
  -Dinsert

Notice that set-properties will be executed recursively on child modules if there are any.
If you don't want the property to be inserted into all of these child modules use the -N option.

[wilx]

Thanks for the contribution. I found two regressions and one gap:

• Properties before a profile’s <id> no longer update; with -Dinsert, this creates a duplicate <properties> block that Maven rejects.
• Stopping at the first matching property regresses repeated property names: Maven uses the last declaration, which the previous implementation updated.
• The existing null-value guard prevents -Dinsert -DprofileId=... from inserting a project/inherited property into a profile lacking a local declaration.

Reproduced all three; 80 selected unit tests pass.

[slachiewicz]

@mandritschke are you still working on this? The three findings from @wilx's review in September are the open items, and the branch needs a rebase onto master, which moved the tests to JUnit 5. If you don't have time, we can carry it forward with your commit and fix the findings on top.

[mandritschke]

Hi,
I've rebased the branch onto the latest master and addressed the two regressions mentioned in the review (thank you @wilx):

• Properties before a profile's <id> should now update correctly.
• The implementation now updates the last declaration of repeated property names.

Inserting into a profile without a local declaration is not done yet.

[mandritschke]

I just updated the PR:

• New profiles can now be inserted as well.