fix(reward): use normalized ToolBench ROUGE thresholds - #10148
Merged
hjh0119 merged 1 commit intoSep 17, 2026
Merged
Conversation
Signed-off-by: Chenghao Liu <chliu@stu.pku.edu.cn>
hjh0119
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
PR information
The ToolBench reward returns zero even for identical plain-text action inputs.
rougesupplies an F1 score in[0, 1], butReactORMcompares it against 10 and 20, so this branch always assigns zero.Use 0.1 and 0.2 for the existing thresholds. The binary reward policy, JSON argument comparison, and tool-name checks remain unchanged.
For example, two identical
Action: search\nAction Input: New York weathercompletions now receive 1 instead of 0; unrelated text and a different tool still receive 0.Experiment results
score_completionspath produces[1, 1, 0, 0]for exact/overlapping/unrelated/wrong-tool completions, versus[0, 0, 0, 0]before the fix (rouge 1.0.1).