fix McpTransportContext.create() mutability issue and add tests - #1076
Merged
Kehrlann merged 1 commit intoAug 7, 2026
Merged
Conversation
iuliiasobolevska
changed the title
Kehrlann
reviewed
Aug 7, 2026
Kehrlann
left a comment
Kehrlann
left a comment
Contributor
There was a problem hiding this comment.
Excellent point. Please fix the header.
| @@ -0,0 +1,89 @@ | |||
| /* | |||
| * Copyright 2024-2025 the original author or authors. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| * Copyright 2024-2025 the original author or authors. | |
| * Copyright 2026-2026 the original author or authors. |
Kehrlann
force-pushed
the
transport-context-immutability
branch
3 times, most recently
from
August 7, 2026 16:26
be94a10 to
434db32
Compare
Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
Kehrlann
force-pushed
the
transport-context-immutability
branch
from
August 7, 2026 16:29
434db32 to
1e123c3
Compare
Kehrlann
self-requested a review
August 7, 2026 16:35
Kehrlann
approved these changes
Aug 7, 2026
Kehrlann
left a comment
Kehrlann
left a comment
Contributor
There was a problem hiding this comment.
Updated and ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #1077.
How Has This Been Tested?
Add new tests that reproduce the issue.
Breaking Changes
No
Types of changes
Checklist
Additional context