atomicwrite: update github.com/moby/sys/sequential v0.7.0 - #243
Draft
thaJeztah wants to merge 1 commit into
Draft
Conversation
thaJeztah
commented
Aug 5, 2026
thaJeztah
commented
Member
- update minimum go version to 1.24
- use os.OpenFile with O_FILE_FLAG_SEQUENTIAL_SCAN on Go 1.26+
- update minimum go version to 1.24 - use os.OpenFile with O_FILE_FLAG_SEQUENTIAL_SCAN on Go 1.26+ Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
There was a problem hiding this comment.
Pull request overview
This PR updates the atomicwriter Go module to align with a newer minimum Go version and to consume the latest github.com/moby/sys/sequential dependency version, along with its transitive golang.org/x/sys update.
Changes:
- Bump
atomicwriter’sgo.modGo version from 1.18 to 1.24 (but currently uses an invalid patch-form directive). - Update
github.com/moby/sys/sequentialdependency from v0.6.0 to v0.7.0. - Update indirect
golang.org/x/sysdependency from v0.1.0 to v0.37.0 and refreshgo.sum.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| atomicwriter/go.mod | Updates module Go version and dependency versions for sequential and x/sys. |
| atomicwriter/go.sum | Refreshes checksums for the updated dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| module github.com/moby/sys/atomicwriter | ||
|
|
||
| go 1.18 | ||
| go 1.24.0 |
Member
Author
There was a problem hiding this comment.
This is forced on us because golang.org/x/sys defines it with a patch version; https://github.com/golang/sys/blob/v0.37.0/go.mod
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.