Skip to content

lora: say when the default model is used, and name the model being loaded - #2047

Open
Srikarmk wants to merge 1 commit into
ml-explore:mainfrom
Srikarmk:lora-name-the-model
Open

Srikarmk wants to merge 1 commit into
ml-explore:mainfrom
Srikarmk:lora-name-the-model

Conversation

@Srikarmk

Copy link
Copy Markdown

While I was training my project, I edited a copy of the training config and accidentally deleted its model: line. When mlx-lm starts training, any setting missing from your config is filled in from its built-in defaults, and the default model is a small one, Qwen/Qwen3-0.6b. So instead of failing or asking, it downloaded that model (about 1.2 GB) and trained it, when you meant Qwen2.5-Coder-1.5B. It did print the model’s name, but only inside a summary box shown after the download had finished.

My change makes mlx-lm say, before anything downloads, “no model was given, so I’m using the default”, which would have caught the mistake straight away.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant