feat(fonts): cover the azerbaijani schwa in montserrat fonts - #393
jamalkamaladdin wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (8)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe two EEZ Studio project files update four LVGL font configurations each. Every configuration adds code points 399 and 601 to its range string and glyph definitions. ChangesLVGL font coverage
Priority: ⬇️ Low — Defer this narrow font update because it adds two Azerbaijani glyphs across eight generated configurations without broader product-impact evidence. Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change adds Azerbaijani schwa glyph coverage across the supported Montserrat font configurations, enabling the characters to render in both display layouts. The configured ranges and glyph metadata are consistent, with no current merge-blocking risk identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks each glyph with care Comment |
|
If you generated this by AI as stated in the description I guess (haven't checked yet) the fonts are now missing the emojis. Can you confirm? |
|
No emojis were removed. compared all four generated fonts in both directories against master. i used ai only for pr description text |
The four generated Montserrat fonts map no codepoint between 383 and 880, so
U+018F (Ə) and U+0259 (ə) render as missing glyph boxes. Both letters are
needed for Azerbaijani, and ə is one of the most frequent letters in the
language.
What changed
generated/ui_320x240andgenerated/ui_240x320, sizes 12, 14, 16 and 20:2 glyphs added per font.
glyph_dscgoes from 1541 to 1543 at 12 and 14 px,and from 747 to 749 at 16 and 20 px. Glyph bitmap data grows by 458 bytes per
generated directory (12 px +70, 14 px +87, 16 px +123, 20 px +178). The rest
of the diff is the
bitmap_indexshift that follows the two new glyphs.studio/320x240/TFT320x240.eez-projectandstudio/240x320/TFTView_240x320.eez-project: the two codepoints added tolvglRangesand tolvglGlyphs.encodingsfor the same four fonts, so aregeneration from EEZ Studio keeps them.
How it was generated
lv_font_conv 1.5.3, with the command line recorded in each font file's own
header and the
MontserratZ-Medium.ttfembedded in the eez-project. Only thehunks carrying the new glyphs were applied to the committed files, so the EEZ
include header and the existing emoji glyph data are unchanged.
Checked locally
All four font files compile against lvgl v9.3.0, the version pinned in
library.json, with the repositoryinclude/lv_conf.h. U+018F and U+0259resolve through the cmap in every size, for example at 16 px with adv_w 209 in
a 13x12 box and adv_w 157 in a 10x9 box. The full CMake build was not run here,
the toolchain is not installed on this machine.
Summary by CodeRabbit