Repository navigation
Fix release environment ref evaluation - #245
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cdf0e44277
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pull_request: | ||
| # Use the trusted base ref so release/production environment policies evaluate | ||
| # this post-merge run as master rather than refs/pull/<number>/merge. | ||
| pull_request_target: |
There was a problem hiding this comment.
Because TextPad is public, this automatic release path will stop queuing after November 2, 2026 if the repository remains under GitHub's default workflow-execution policy, which will block pull_request_target; the repository's canonical protection configuration and audit currently do not configure or verify an explicit event-policy exception. Add and audit an allow policy for this event, or use a trusted trigger that is not subject to the block, so merging a release PR continues to initiate publication. See GitHub's workflow execution policy documentation.
Useful? React with 👍 / 👎.
1 participant
Summary
Why
The first v1.31.2 automatic run was rejected before executing any step because a pull_request run deploys as refs/pull/244/merge, which is correctly excluded by the release environment policy. pull_request_target evaluates the already-merged event against master while the job-level guard still rejects unmerged and non-release PRs.
Validation