Repository navigation
Release 1.31.2 - #244
Release 1.31.2#244
Conversation
…s_pr_fix fix code review suggestions
…s_test update tests
…e-workflow Streamline Android release workflow
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca1b9293ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1 @@ | |||
| TODO: RELEASE NOTES (1.31.2) | |||
There was a problem hiding this comment.
This file, along with the other three newly added 63.txt changelogs, still contains a configured TODO: RELEASE NOTES marker. validate_changelogs() explicitly rejects any such marker, and release-pr.yml runs that validation as a required release check, so this release cannot pass validation or reach tag creation until every localized placeholder is replaced.
Useful? React with 👍 / 👎.
| private void stopActivePanning(View view) { | ||
| if (panningActive) { | ||
| requestParentInterception(view, false); | ||
| } |
There was a problem hiding this comment.
In the standard-scrolling layout, lifting either finger calls this method while panGestureOwned remains true, but this line immediately allows the surrounding ScrollView to intercept again. A subsequent move of the remaining finger can therefore be intercepted and vertically scroll the document using the original down position, despite the listener intending to consume all remaining events until the final up; retain the interception lock until endPanGesture() handles ACTION_UP or ACTION_CANCEL.
Useful? React with 👍 / 👎.
This branch had an error being deployed
1 participant
Release checklist