Skip to content

Fix Turkish locale in the plugin manifest schema - #467

Merged
ggbond268 merged 1 commit into
mactools-app:mainfrom
Egv2:fix-manifest-schema-turkish
Oct 6, 2026
Merged

ggbond268 merged 1 commit into
mactools-app:mainfrom
Egv2:fix-manifest-schema-turkish

Conversation

@Egv2

@Egv2 Egv2 commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Problem and result

Follow-up to #462. The schema's required locale lists gained tr, but the matching properties entries in completeLocalizedText and completeLocalizedStringArrays were missed, so with additionalProperties: false Turkish is both required and forbidden and every plugin manifest fails JSON Schema validation on main. This adds the missing tr properties so the manifests validate again.

Changes

Two properties maps in docs/plugins/plugin-manifest.schema.json now include tr.

Verification

  • jsonschema validation of all 63 plugin manifests: 63 of 63 failed on main, 62 of 63 pass with this fix. The one remaining failure is pre-existing and unrelated, the permission enum lacks full-disk-access that DiskClean declares and the Python validator accepts. Happy to fix that separately if wanted.
  • make script-tests: 221 tests pass.

UI evidence

Not applicable, schema documentation only.

Checklist

  • Core behavior and relevant risks are verified using existing tests, focused additions, or manual checks; results or limitations are recorded.
  • UI evidence is attached where applicable; shared components, themes, localization, and accessibility are respected.
  • User-facing documentation and changelog fragments are updated when required.
  • Plugin metadata, runtime contracts, action policies, and minimum-host compatibility agree.
  • Licensing and third-party notices are complete; no credentials, local configuration, or unrelated generated files are included.

Follow-up to the Turkish localization PR: the required locale lists
gained tr, but the matching properties entries in
completeLocalizedText and completeLocalizedStringArrays were missed,
so additionalProperties: false made Turkish both required and
forbidden and schema validation rejected every manifest.
@ggbond268
ggbond268 merged commit 3ca4c6f into mactools-app:main Oct 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants