Repository navigation
Fix Turkish locale in the plugin manifest schema - #467
Merged
Merged
Conversation
Follow-up to the Turkish localization PR: the required locale lists gained tr, but the matching properties entries in completeLocalizedText and completeLocalizedStringArrays were missed, so additionalProperties: false made Turkish both required and forbidden and schema validation rejected every manifest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
Follow-up to #462. The schema's
requiredlocale lists gainedtr, but the matchingpropertiesentries incompleteLocalizedTextandcompleteLocalizedStringArrayswere missed, so withadditionalProperties: falseTurkish is both required and forbidden and every plugin manifest fails JSON Schema validation on main. This adds the missingtrproperties so the manifests validate again.Changes
Two
propertiesmaps indocs/plugins/plugin-manifest.schema.jsonnow includetr.Verification
jsonschemavalidation of all 63 plugin manifests: 63 of 63 failed on main, 62 of 63 pass with this fix. The one remaining failure is pre-existing and unrelated, thepermissionenum lacksfull-disk-accessthat DiskClean declares and the Python validator accepts. Happy to fix that separately if wanted.make script-tests: 221 tests pass.UI evidence
Not applicable, schema documentation only.
Checklist