Skip to content

Remove debug print from remove_fields - #92

Open
homebysix wants to merge 1 commit into
macadmins:mainfrom
homebysix:remove-debug-print
Open

Remove debug print from remove_fields#92
homebysix wants to merge 1 commit into
macadmins:mainfrom
homebysix:remove-debug-print

Conversation

@homebysix

Copy link
Copy Markdown
Contributor

remove_fields() has a leftover print("Array item: ", i) that fires for every element of every list passed through a model's .xml() method. It's been in there since the open source release.

We noticed it in an AWS Lambda that adds computers to a static group with update_static_computer_group_membership_by_id(). One run wrote about 1,900 lines of Array item: {'id': 1234} to CloudWatch alongside the real log output, and it grows with the size of the membership update. Since it's a print and not a logger call, there's no way to quiet it from the caller.

Thanks for considering!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant