Repository navigation
Review codebase and implement high-impact fix - #103
Merged
Merged
Conversation
Add defensive check before StringPosition call in AMReX.wl and
CarpetXGPU.wl. Previously, if a tensorname didn't start with 'd',
the code assumed it must contain 'd' somewhere. If this assumption
was violated, StringPosition returned {} and [[-1]][[1]] crashed
with Part::pkspec1.
Now uses Which[] to explicitly check if 'd' exists in the string
before accessing its position, and throws a clear error message
if the derivative tensor name is malformed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add defensive check before StringPosition call in AMReX.wl and CarpetXGPU.wl. Previously, if a tensorname didn't start with 'd', the code assumed it must contain 'd' somewhere. If this assumption was violated, StringPosition returned {} and [[-1]][[1]] crashed with Part::pkspec1.
Now uses Which[] to explicitly check if 'd' exists in the string before accessing its position, and throws a clear error message if the derivative tensor name is malformed.