Skip to content

SP-3209: add DP2 NBs for LSB science - #191

Open
garrethmartin wants to merge 2 commits into
mainfrom
SP-3209
Open

SP-3209: add DP2 NBs for LSB science#191
garrethmartin wants to merge 2 commits into
mainfrom
SP-3209

Conversation

@garrethmartin

Copy link
Copy Markdown
Contributor

migrating DP1 LSB notebooks to DP2

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@MelissaGraham MelissaGraham changed the title SP 3209 SP-3209: add DP2 NBs for LSB science Aug 12, 2026
@@ -0,0 +1,694 @@
{

@christinawilliams christinawilliams Aug 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For bounding box access, is 104.5 the notebook you mean to reference?


Reply via ReviewNB

@@ -0,0 +1,694 @@
{

@christinawilliams christinawilliams Aug 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to delete the old commented code here.

Also just to check, I think skymap is now not needed to retrieve the patch and tract? I don't know for sure, I just remember removing skymap from my earlier DP1 notebooks when transitioning to DP2 (maybe the feature was either previously not working, or DM was trying to de-emphasize its use, I can't remember now)


Reply via ReviewNB

@@ -0,0 +1,1304 @@
{

@christinawilliams christinawilliams Aug 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to remove commented text


Reply via ReviewNB

@@ -0,0 +1,732 @@
{

@christinawilliams christinawilliams Aug 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to remove commented text


Reply via ReviewNB

@christinawilliams christinawilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few very minor updates are needed but I have approved the PR so you can merge once they are done! Nice job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants