Repository navigation
[crypto] Add CMVP service indicator and approval checks - #31277
Merged
Merged
Conversation
siemen11
requested review from
a team and
alees24
and removed request for
a team
September 10, 2026 14:27
siemen11
force-pushed
the
service_indicator
branch
from
September 10, 2026 14:28
c88a87a to
791a34b
Compare
siemen11
requested review from
andrea-caforio,
johannheyszl and
nasahlpa
and removed request for
alees24
September 10, 2026 14:28
siemen11
force-pushed
the
service_indicator
branch
2 times, most recently
from
September 10, 2026 15:17
44f80e1 to
313f5da
Compare
siemen11
added a commit
to siemen11/opentitan
that referenced
this pull request
Sep 10, 2026
Add a service indicator showing whether a crypto function was allowed concerning CMVP or not. In addition, this indicator reflects: - We limit the key size on KDFs (minimum 112-bit key length for KDF-CTR and KMAC-KDF). - We limit the usage of RSA (RSA-2048 key generation marked non-approved per SP 800-131A; only 3072 and 4096 are approved). - We limit HMAC key size (minimum 112-bit key length for approved generation). - We limit CMAC tag size (minimum 64-bit tag length per SP 800-38B). - We distinguish DRBG entropy sources (hardware-seeded CSRNG generation is approved; manual/external seeding is non-approved). - We mark non-approved algorithms as non-approved (e.g., HKDF, X25519). Signed-off-by: Siemen Dhooghe <sdhooghe@google.com>
siemen11
force-pushed
the
service_indicator
branch
2 times, most recently
from
September 10, 2026 16:35
8f4b270 to
888c669
Compare
andrea-caforio
approved these changes
Sep 11, 2026
andrea-caforio
left a comment
andrea-caforio
left a comment
Contributor
There was a problem hiding this comment.
Thanks @siemen11.
siemen11
force-pushed
the
service_indicator
branch
3 times, most recently
from
September 11, 2026 22:03
8c3eb46 to
ab4aa6e
Compare
siemen11
force-pushed
the
service_indicator
branch
from
September 17, 2026 09:48
ab4aa6e to
1ace54e
Compare
Add a service indicator showing whether a crypto function was allowed concerning CMVP or not. In addition, this indicator reflects: - We limit the key size on KDFs (minimum 112-bit key length for KDF-CTR and KMAC-KDF). - We limit the usage of RSA (RSA-2048 key generation marked non-approved per SP 800-131A; only 3072 and 4096 are approved). - We limit HMAC key size (minimum 112-bit key length for approved generation). - We limit CMAC tag size (minimum 64-bit tag length per SP 800-38B). - We distinguish DRBG entropy sources (hardware-seeded CSRNG generation is approved; manual/external seeding is non-approved). - We mark non-approved algorithms as non-approved (e.g., HKDF, X25519). Signed-off-by: Siemen Dhooghe <sdhooghe@google.com>
siemen11
force-pushed
the
service_indicator
branch
from
September 17, 2026 15:09
1ace54e to
232a8b6
Compare
Contributor
Author
|
Merging as failing tests are unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a service indicator showing whether a crypto function was allowed concerning CMVP or not.
In addition, this indicator reflects: