Repository navigation
[manuf] Move default perso extensions outside of extension - #31269
Conversation
5fa0c34 to
93c5731
Compare
| name = "default_perso_fw_ext", | ||
| srcs = ["default_personalize_ext.c"], | ||
| deps = [ | ||
| "@lowrisc_opentitan//sw/device/lib/dif:flash_ctrl", |
There was a problem hiding this comment.
Note: technically, all those @lowrisc_opentitan references are not needed since package is part of lowrisc_opentitan. I kept it since it was present and it at least provided a very easy file to copy-paste to extension, so might be worth keeping?
df88333 to
e6013a5
Compare
I agree. Currently, the downstream code has alias targets that point to build targets with source files that are copies of the upstream default extension code. For ML-DSA default extension alias in the downstream code, I added an alias target that points back to the upstream Having this changes would allow removing these alias targets in the downstream code. |
|
This PR only moves the files so it should be relatively harmless but if you have work in progress and want to avoid rebase conflicts, we can keep this open until all MLDSA changes are done. |
I would prefer to merge this after reviews and use it downstream |
AlexJones0
left a comment
There was a problem hiding this comment.
LGTM after my comments are addressed. Thanks @pamaury.
adcf6cf to
802b175
Compare
Those files are used in the provisioning inputs of the OT repository unconditionally. This means that when the provisioning extension module gets overriden by the manufacturer, references like @provisioning_exts//:default_ft_ext_lib will now point to manufacturer code instead of the "default"/example provisioning code. At best, this can produce a compile error and at worse produce a non-functional perso/rom_ext when building the emulation skus. This commit moves those default files outside of the extension so that they can be referenced even when overriding the extension. Signed-off-by: Amaury Pouly <amaury.pouly@opentitan.org>
802b175 to
8c384ef
Compare
|
I have rebased since there were some recent changes but I tested locally and it works. |
|
I have tried cherry-picking #30906 to see if it helps with the USB problems. |
d8d24ee to
8c384ef
Compare
|
CI failures are due to some CI problems with the CW310. All manufacturing tests passed on the CW340 so this should be safe to merge. |
Those files are used in the provisioning inputs of the OT repository unconditionally. This means that when the provisioning extension module gets overriden by the manufacturer, references like @provisioning_exts//:default_ft_ext_lib will now point to manufacturer code instead of the "default"/example provisioning code. At best, this can produce a compile error and at worse produce a non-functional perso/rom_ext when building the emulation skus.
This commit moves those default files outside of the extension so that they can be referenced even when overriding the extension.
Context: without this, using the
ot-skurepository as a provisioning extension breaks all emulation skus.